| 16 May 2024 |
 @jade_:matrix.org | no worries everyone screws this up | 20:38:04 |
| @jade_:matrix.org | i actually think i screwed this up recently!! | 20:38:12 |
| @jade_:matrix.org | i fixed the buildbot recursion structure, but i only fixed overlaying the package set, not "one off .overrideAttrs" | 20:38:57 |
| @jade_:matrix.org | because i didn't know about finalAttrs.finalPackage until today | 20:39:16 |
 vringar | Btw how hard is it to write a lint for nixpkgs. I kinda want to try my hand at creating a lint for "if you overwrite a phase you should run it's pre and post hooks" | 20:39:50 |
 Lily Foster | In reply to @ff-vringar:mozilla.org
Btw how hard is it to write a lint for nixpkgs. I kinda want to try my hand at creating a lint for "if you overwrite a phase you should run it's pre and post hooks" i mean something like nixpkgs-hammering does have some lints, and that is already one of them | 20:40:07 |
| Lily Foster | but nixpkgs-hammering probably has other issues. idk i haven't bothered with it in ages | 20:40:33 |
| @jade_:matrix.org | nixpkgs-hammering should actually get ci'd | 20:40:35 |
| @jade_:matrix.org | also it bothers you about things being in funny order which is honestly just Weird | 20:40:46 |
| Lily Foster | In reply to @jade_:matrix.org
also it bothers you about things being in funny order which is honestly just Weird yeahh | 20:40:56 |
| Lily Foster | (this is what we're referring to, if anyone wanted a link: https://github.com/jtojnar/nixpkgs-hammering) | 20:41:14 |
 thubrecht | In reply to @jade_:matrix.org
also it bothers you about things being in funny order which is honestly just Weird I believe it makes it easier to find different attributes in a big file | 20:42:15 |
 Grimmauld (moving to @grimmauld:grapevine.grimmauld.de) | it makes some sense to have the phases ordered as they happen and sources before phases before meta and such. Keeps things readable. But hammering is obnoxiously loud about it and then half the time the issue is in the underlying derivation builder! | 20:45:26 |
| vringar | In reply to @jade_:matrix.org
https://github.com/NixOS/nixpkgs/pull/310343#discussion_r1603982324 something like this 🎉 and it works! Thank you all so much | 20:46:42 |
 @fly:asra.gr | In reply to @lily:lily.flowers
(this is what we're referring to, if anyone wanted a link: https://github.com/jtojnar/nixpkgs-hammering) wait... can that tool save us from 10 review rounds on nixpkgs PRs? | 20:48:25 |
| @jade_:matrix.org | In reply to @ff-vringar:mozilla.org
🎉 and it works! Thank you all so much https://github.com/NixOS/nixpkgs/pull/310343/files#r1604011494 dammit, i found another one by thinking harder about the other stuff in passthru 🙃 | 20:50:06 |
| vringar | In reply to @jade_:matrix.org
https://github.com/NixOS/nixpkgs/pull/310343/files#r1604011494 dammit, i found another one by thinking harder about the other stuff in passthru 🙃 I'm happy to get as thorough of a review as possible. I can imagine no better way of learning this tool | 20:51:18 |
| @jade_:matrix.org | we would really love to have tools teach people for us because there's only so many catgirls | 20:51:46 |
| @jade_:matrix.org | but we do love to teach people things | 20:51:59 |
| @jade_:matrix.org | 
Download image.png | 21:15:23 |
| @jade_:matrix.org | i think this is what you need, i can push it to your branch if you'd like | 21:15:27 |
| Grimmauld (moving to @grimmauld:grapevine.grimmauld.de) | In reply to @jade_:matrix.org
we would really love to have tools teach people for us because there's only so many catgirls i mean you could try filling the vacancies with shrimp guys... Though chitin != fur, not sure how well that'd work.-. | 21:15:52 |
| @jade_:matrix.org | lmao | 21:16:06 |
| vringar | In reply to @jade_:matrix.org
i think this is what you need, i can push it to your branch if you'd like Yes, that would be great.
I'll also try to figure out a test extension that verifies that this whole setup actually works | 21:25:57 |
| @jade_:matrix.org | alright pushed it | 21:42:13 |
| @jade_:matrix.org | also did you intentionally remove emily as maintainer in the extensions? | 21:42:22 |
 emilytrau | yep :) | 21:47:59 |
 Charles | In reply to @jade_:matrix.org
sent an image. what are you using that produces diffs like this | 21:49:05 |
| @jade_:matrix.org | In reply to @charles:computer.surgery
what are you using that produces diffs like this delta | 21:49:25 |
| @jade_:matrix.org | (reasons i send people screenshots of nice things i have: they can improve their lives :3) | 21:49:42 |
