| 20 Oct 2025 |
raitobezarius | 0812ddeb09f284da134ad2c35a7175b46b7e5a88 | 19:03:19 |
raitobezarius | is the fix in cppnix | 19:03:21 |
raitobezarius | commit 0812ddeb09f284da134ad2c35a7175b46b7e5a88
Author: Alyssa Ross <hi@alyssa.is>
Date: Wed Apr 17 21:51:59 2024 +0200
Fix exportReferencesGraph when given store subpath
With Nix 2.3, it was possible to pass a subpath of a store path to
exportReferencesGraph:
with import <nixpkgs> {};
let
hello = writeShellScriptBin "hello" ''
echo ${toString builtins.currentTime}
'';
in
writeClosure [ "${hello}/bin/hello" ]
This regressed with Nix 2.4, with a very confusing error message, that
presumably indicates it was unintentional:
error: path '/nix/store/3gl7kgjr4pwf03f0x70dgx9ln3bhl7zc-hello/bin/hello' is not in the Nix store
(cherry picked from commit 0774e8ba33c060f56bad3ff696796028249e915a)
src/libstore/parsed-derivations.cc
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
──────────────────────────────────────────────────────────────────────────────────────┐
151: std::optional<nlohmann::json> ParsedDerivation::prepareStructuredAttrs(Store & s │
──────────────────────────────────────────────────────────────────────────────────────┘
for (auto i = e->begin(); i != e->end(); ++i) {
StorePathSet storePaths;
for (auto & p : *i)
storePaths.insert(store.parseStorePath(p.get<std::string>()));
storePaths.insert(store.toStorePath(p.get<std::string>()).first);
json[i.key()] = store.pathInfoToJSON(
store.exportReferences(storePaths, inputPaths), false, true);
}
| 19:03:40 |
raitobezarius | * commit 0812ddeb09f284da134ad2c35a7175b46b7e5a88
Author: Alyssa Ross <hi@alyssa.is>
Date: Wed Apr 17 21:51:59 2024 +0200
Fix exportReferencesGraph when given store subpath
With Nix 2.3, it was possible to pass a subpath of a store path to
exportReferencesGraph:
with import <nixpkgs> {};
let
hello = writeShellScriptBin "hello" ''
echo ${toString builtins.currentTime}
'';
in
writeClosure [ "${hello}/bin/hello" ]
This regressed with Nix 2.4, with a very confusing error message, that
presumably indicates it was unintentional:
error: path '/nix/store/3gl7kgjr4pwf03f0x70dgx9ln3bhl7zc-hello/bin/hello' is not in the Nix store
(cherry picked from commit 0774e8ba33c060f56bad3ff696796028249e915a)
diff --git a/src/libstore/parsed-derivations.cc b/src/libstore/parsed-derivations.cc
index cc4a94fab..96ed15518 100644
--- a/src/libstore/parsed-derivations.cc
+++ b/src/libstore/parsed-derivations.cc
@@ -151,7 +151,7 @@ std::optional<nlohmann::json> ParsedDerivation::prepareStructuredAttrs(Store & s
for (auto i = e->begin(); i != e->end(); ++i) {
StorePathSet storePaths;
for (auto & p : *i)
- storePaths.insert(store.parseStorePath(p.get<std::string>()));
+ storePaths.insert(store.toStorePath(p.get<std::string>()).first);
json[i.key()] = store.pathInfoToJSON(
store.exportReferences(storePaths, inputPaths), false, true);
}
| 19:04:05 |
raitobezarius | actually, i should correct myself | 19:05:24 |
raitobezarius | happened since 2.4, fixed in 2.18.9 | 19:05:32 |
raitobezarius | (and we also had that bug — https://gerrit.lix.systems/c/lix/+/867) | 19:08:01 |
raitobezarius | but i don't remember if it made it into any release of Lix | 19:08:13 |
QuadRadical (Ping) | btw raito | 19:08:23 |
QuadRadical (Ping) | any news on that issue with the freezee? | 19:08:33 |
QuadRadical (Ping) | * any news on that issue with the freeze? | 19:08:36 |
raitobezarius | yeah, i'm really sorry, i was resting this weekend and well $JOB was busy today | 19:11:45 |
raitobezarius | QuadRadical (Ping): can you point me again the repo and the instruction to reproduce? | 19:11:52 |
raitobezarius | I will take a look right now | 19:11:55 |
raitobezarius | * yeah, i'm really sorry, i was resting [actually a lie: i was in a conference and busy again] this weekend and well $JOB was busy today | 19:12:12 |
QuadRadical (Ping) | sure! | 19:33:49 |
QuadRadical (Ping) | https://codeberg.org/polyphony/chorus | 19:33:57 |
QuadRadical (Ping) | NIX_REMOTE=local sudo nix build --no-sandbox .#checks.x86_64-linux.nextest | 19:36:00 |
raitobezarius | how does that work? | 19:41:20 |
raitobezarius | i don't see a flake.nix | 19:41:22 |
raitobezarius | Henry-Hiles/chorus:dev | 19:41:51 |
raitobezarius | sounds like what I want | 19:41:54 |
raitobezarius | now, it's running | 19:42:13 |
QuadRadical (Ping) | ah, sorry yeah | 19:42:20 |
QuadRadical (Ping) | i forgor | 19:42:33 |
QuadRadical (Ping) | yeah its that one | 19:43:59 |
raitobezarius | ❯ NIX_REMOTE=local sudo nix build --no-sandbox .#checks.x86_64-linux.nextest
error: build of '/nix/store/8095y0kvb7xxzf8vxclyn9qmsaixr2pq-chorus-nextest-0.20.0.drv' on 'ssh://build01-x86-newtype' failed: builder for '/nix/store/8095y0kvb7xxzf8vxclyn9qmsaixr2pq-chorus-nextest-0.20.0.drv' failed with exit code 100;
last 25 log lines:
> PASS [ 2.344s] chorus::channels get_channel_messages1m17 failed, 0 skipped
> Running [ 00:00:02] 79/80: 1 running, 62 passed, 17 failed, 0 skipped [WebSocket] closed 1006
> [WebSocket] closed 1006
> [WebSocket] closed 1006
> PASS [ 2.391s] chorus::auth test_wrong_login, 17 failed, 0 skipped
> ------------ing [ 00:00:02] 80/80: 0 running, 63 passed, 17 failed, 0 skipped
> Summary [ 2.392s] 80 tests run: 63 passed, 17 failed, 0 skipped
> FAIL [ 1.934s] chorus::auth test_login
> FAIL [ 1.678s] chorus::auth test_registration
> FAIL [ 1.734s] chorus::channels create_dm
> FAIL [ 1.793s] chorus::guilds guild_create_ban
> FAIL [ 1.933s] chorus::guilds guild_remove_member
> FAIL [ 1.918s] chorus::invites create_accept_invite
> FAIL [ 0.807s] chorus::messages test_stickies
> FAIL [ 1.872s] chorus::relationships test_get_mutual_relationships
> FAIL [ 1.821s] chorus::relationships test_get_relationships
> FAIL [ 1.924s] chorus::relationships test_modify_relationship_block
> FAIL [ 1.740s] chorus::relationships test_modify_relationship_friends
> FAIL [ 0.882s] chorus::user test_disable_user
> FAIL [ 0.822s] chorus::user test_get_connections
> FAIL [ 0.845s] chorus::user test_get_guild_affinities
> FAIL [ 0.899s] chorus::user test_get_user_affinities
> FAIL [ 0.865s] chorus::user test_get_user_profile
> FAIL [ 0.881s] chorus::user test_modify_user_profile
> error: test run failed80/80: 0 running, 63 passed, 17 failed, 0 skipped
For full logs, run:
nix log /nix/store/8095y0kvb7xxzf8vxclyn9qmsaixr2pq-chorus-nextest-0.20.0.drv
error: builder for '/nix/store/8095y0kvb7xxzf8vxclyn9qmsaixr2pq-chorus-nextest-0.20.0.drv' failed on remote builder
| 19:47:34 |
raitobezarius | cannot reproduce being stuck | 19:47:37 |
raitobezarius | i will try more stuff to reduce the likelihood it comes from some magical piece of my environment | 19:47:55 |
QuadRadical (Ping) | In a game will look after thx | 19:48:09 |