| 7 May 2023 |
 figsoda | no actually List would work just fine | 21:53:49 |
| figsoda | but maybe we want to have hints to suggest the available builders | 21:54:30 |
| figsoda | idk | 21:54:30 |
| figsoda | anything works | 21:54:38 |
 raitobezarius | available builders would require to compute them right? | 21:54:53 |
| figsoda | sorry, could you elaborate on that? | 21:55:46 |
| raitobezarius |
but maybe we want to have hints to suggest the available builders
if I have a list of source root candidates, what do you mean by suggesting the available builders?
| 21:56:05 |
| raitobezarius | my source root candidates list is already made of subfolders which contains an appropriate build system file | 21:56:18 |
| raitobezarius | the only way to hint about the buildable ones would be to compute the rust_vendors, etc. | 21:56:31 |
| raitobezarius | or are you talking about something else? | 21:56:36 |
| figsoda | In reply to @raitobezarius:matrix.org
the only way to hint about the buildable ones would be to compute the rust_vendors, etc. oh yeah that would probably be too much for e.g. python packages | 21:57:30 |
| figsoda | I would say showing the files found is good, something like bindings/rust (Cargo.lock, Cargo.toml), bindings/python (pyproject.toml) | 21:58:31 |
| raitobezarius | hmm | 21:58:55 |
| raitobezarius | then List does not cut it | 21:58:59 |
| raitobezarius | I won't do this part right now right now | 21:59:09 |
| raitobezarius | I will hack a workable version for my packaging | 21:59:13 |
| raitobezarius | and then we can improve it | 21:59:15 |
| raitobezarius | I'm almost done with v1 | 21:59:22 |
| figsoda | if that's too much we can improve it later | 21:59:23 |
| raitobezarius | what does | 22:00:01 |
| raitobezarius | let Some(Prompter::Build(choices)) = editor.helper_mut() else {
unreachable!();
};
| 22:00:03 |
| raitobezarius | means? | 22:00:04 |
| raitobezarius | * mean? | 22:00:07 |
| raitobezarius | like choice is already an index right? | 22:00:48 |
| raitobezarius | I just need to reuse my structure? | 22:00:52 |
| raitobezarius | or is this because of consumption? | 22:00:57 |
| figsoda | In reply to @raitobezarius:matrix.org
let Some(Prompter::Build(choices)) = editor.helper_mut() else {
unreachable!();
};
2 lines above set_helper takes ownership of choices, this is taking it back | 22:01:34 |
| raitobezarius | okay you're consuming it back | 22:01:47 |
| raitobezarius | I won't do it this way | 22:02:01 |
| raitobezarius | It's a bit ugly | 22:02:04 |
