14 Jul 2023 |
@kranzes:matrix.org | nice work on that | 20:51:13 |
figsoda |
the git summary, e.g. v1.0.0-10-g34f56g3
| 20:51:58 |
figsoda | ok its the git summary | 20:52:01 |
@kranzes:matrix.org | other than these 2 things and i guess meta.mainProgram looks identical to the one in nixpkgs | 20:52:04 |
figsoda | i think ill just do something like ${src.rev}-00000000 | 20:52:24 |
@kranzes:matrix.org | it should just be $version | 20:52:36 |
@kranzes:matrix.org | all the time | 20:52:43 |
figsoda | well we don't know what people are doing with these templates | 20:53:01 |
figsoda | maybe they are parsing it (why?) | 20:53:06 |
@kranzes:matrix.org | https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/continuous-integration/gitea-actions-runner/default.nix#L23 | 20:53:21 |
@kranzes:matrix.org | that's what we got right now anyway | 20:53:25 |
figsoda | lol | 20:53:30 |
@kranzes:matrix.org | so pretty similar | 20:53:42 |
@kranzes:matrix.org | btw hexa check the PR i just made for this | 20:54:08 |
hexa | no need to ping me here as well | 20:54:21 |
@kranzes:matrix.org | I just saw you were lurking here already lol | 20:54:35 |
figsoda |
It is generated by git describe --dirty --always --tags , the format will be {Tag}-$N-{CommitSHA}
| 20:55:31 |
@kranzes:matrix.org | https://github.com/nix-community/nix-init/issues/184
is this not just another fetcher? | 20:55:55 |
@kranzes:matrix.org | shouldn't this be in nurl ? | 20:56:01 |
figsoda | nurl already supports it | 20:56:08 |
figsoda | but nix-init doesn't the metadata fetching | 20:56:18 |
figsoda | * but nix-init does the metadata fetching | 20:56:25 |
@kranzes:matrix.org | Oh, right | 20:56:52 |
@kranzes:matrix.org | i see | 20:56:54 |
figsoda | I checked the git describe --dirty --always --tags output of a few repositories, looks like parsing it would be super reliable, I think I will just do src.rev , or shorten it if it is a sha | 20:58:59 |