| 8 May 2023 |
raitobezarius | and of course pythonRelaxDeps doesn't work | 00:00:45 |
raitobezarius | well well enough hacking | 00:00:48 |
figsoda | In reply to @raitobezarius:matrix.org and of course pythonRelaxDeps doesn't work did you add the hook? | 00:01:10 |
raitobezarius | aaaaaaaaaaaaah | 00:01:15 |
raitobezarius | no | 00:01:16 |
raitobezarius | let's try with the hook | 00:01:35 |
raitobezarius | nice | 00:01:39 |
raitobezarius | pythonImportsCheck = [ "opentelemetry-api" ]; | 00:01:44 |
raitobezarius | is automatically generated by nix-init | 00:01:49 |
raitobezarius | ? | 00:01:50 |
raitobezarius | and is wrong | 00:01:51 |
figsoda | hmm it should generate opentelemetry_api | 00:02:30 |
figsoda | this is a bug | 00:02:33 |
raitobezarius | (which is also wrong) | 00:02:35 |
raitobezarius | (but it's fine) | 00:02:37 |
raitobezarius | (it's opentelemetry in my caseā¦) | 00:02:44 |
raitobezarius | (I'm starting to hate OTEL) | 00:02:48 |
figsoda | I don't think it's possible for nix-init to tell | 00:03:04 |
figsoda | idk | 00:03:04 |
raitobezarius | I think it is | 00:03:10 |
raitobezarius | but it would require more advanced Python integration code | 00:03:15 |
raitobezarius | I have some ideas | 00:03:16 |
figsoda | btw I'm writing documentation for haumea | 00:04:37 |
figsoda | I will get to your PR tmr | 00:04:44 |
raitobezarius | of course I was not waiting immediate merge | 00:04:55 |
raitobezarius | I need to clean it up | 00:04:57 |
figsoda | I took a quick look and found one small issue | 00:08:23 |
figsoda | not a full review | 00:08:36 |
raitobezarius | this is misparsed: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-botocore/pyproject.toml#L38 | 00:20:12 |
raitobezarius | it should expand and resolve | 00:20:20 |