| 11 Nov 2021 |
| Cleeyv joined the room. | 18:14:25 |
| 12 Nov 2021 |
andi- | Give the "whell" a white outline and that should fix it. | 12:23:25 |
andi- | * Give the "wheel" a white outline and that should fix it. | 12:23:28 |
| bbigras joined the room. | 16:05:25 |
| 17 Nov 2021 |
| Linux Hackerman is moving: @linus:schreibt.jetzt joined the room. | 08:33:28 |
| towesfeb joined the room. | 21:07:19 |
| 18 Nov 2021 |
| Mark joined the room. | 21:50:00 |
Mark | hey, how can i patch a dependency vendored by Nix? | 21:51:22 |
Mark | i'm trying to update Deno, but for that i need to patch rusty_v8 crate's build.rs | 21:51:43 |
Mark | https://github.com/NixOS/nixpkgs/pull/146543/files#diff-978687fc2d0854b777ef29c688b25d5a64379b23f67ebd18becc0dc1cb76fbf6R44 | 21:52:38 |
Mark | no luck so far | 21:52:41 |
Mark | i've considered copying the dependency, and changing Cargo.toml, but that's a bit stretch | 21:53:26 |
Mark | alternatively, i can try fixing this on upstream | 21:53:48 |
jonringer | you're looking for cargoPatches | 21:54:08 |
Mark | rusty_v8 build.rs insists on deleting the downloaded .a file now | 21:54:09 |
jonringer | which will apply before vendoring | 21:54:23 |
jonringer | downloading a precompiled binary at build time is a no-no. I would create an issue upstream to some how specify it. | 21:55:05 |
Mark | In reply to @jonringer:matrix.org which will apply before vendoring before vendoring, in other words when vendored dependencies are not available yet | 21:56:06 |
Mark | then cargoPatches isn't a thing i'm looking for | 21:56:27 |
Mark | because i need to patch the vendored dependency, not project (Deno) itself | 21:56:47 |
Mark | In reply to @jonringer:matrix.org downloading a precompiled binary at build time is a no-no. I would create an issue upstream to some how specify it. of course, current Deno derivation is downloading prebuilt v8 .a file from github and placing it into a directory where rusty_v8 would download & put it | 21:58:14 |
Mark | right now rusty_v8 insists on deleting the file | 21:58:35 |
Mark | alternatively i can just set V8_FROM_SOURCE=1 and build V8 from source | 21:59:24 |
jonringer | In reply to @mikroskeem:d0.ee alternatively i can just set V8_FROM_SOURCE=1 and build V8 from source this looks like it tries to build it from a submodule, which is also bad | 22:00:21 |
jonringer | https://github.com/denoland/rusty_v8 should really allow you a way to just say, "V8_STATIC_LIB=${pkgsStatic.v8}/lib/v8.a" | 22:01:25 |
jonringer | or even better yet, attempt pkg-config --static --libs v8 | 22:02:27 |
Mark | hm wait, RUSTY_V8_MIRROR is a thing | 22:05:54 |
Mark | clearly didn't RTFM enough | 22:06:15 |
Mark | and so is RUSTY_V8_ARCHIVE | 22:09:10 |
| 19 Nov 2021 |
| uep joined the room. | 22:30:31 |