| 8 Nov 2021 |
 Yureka (she/her) | or some git branch/tag was yanked? | 16:51:30 |
 legendofmiracles | Or commit | 16:51:37 |
| legendofmiracles | I'll play around a bit, thanks for the hint | 16:51:52 |
 lourkeur (nix btw) | In reply to @jonringer:matrix.org
if you do need to apply patches before vendoring, you can declare them with cargoPatches Interesting. I didn't know that so I used this pattern instead recently. Would cargoPatches be preferable in this case?
cargoDeps = rustPlatform.fetchCargoTarball {
inherit src patches;
name = "${pname}-${version}";
```https://github.com/NixOS/nixpkgs/pull/144733/files#diff-a35bcf6b38716a31d2a5ea43b4ff2e6217c591817597572a22d560fa86ba0bb8R28
| 16:54:11 |
| lourkeur (nix btw) | In reply to @jonringer:matrix.org
if you do need to apply patches before vendoring, you can declare them with cargoPatches * Interesting. I didn't know that so I used this pattern instead recently. Would cargoPatches be preferable in this case?
cargoDeps = rustPlatform.fetchCargoTarball {
inherit src patches;
name = "${pname}-${version}";
}
https://github.com/NixOS/nixpkgs/pull/144733/files#diff-a35bcf6b38716a31d2a5ea43b4ff2e6217c591817597572a22d560fa86ba0bb8R28
| 16:54:22 |
| lourkeur (nix btw) | * Interesting. I didn't know that so I used this pattern instead recently. Would cargoPatches be preferable in this case?
cargoDeps = rustPlatform.fetchCargoTarball {
inherit src patches;
name = "${pname}-${version}";
}
https://github.com/NixOS/nixpkgs/pull/144733/files#diff-a35bcf6b38716a31d2a5ea43b4ff2e6217c591817597572a22d560fa86ba0bb8R28
| 16:54:39 |
| lourkeur (nix btw) | * Interesting. I didn't know that so I used this pattern instead recently. Would cargoPatches be preferable in this case?
cargoDeps = rustPlatform.fetchCargoTarball {
inherit src patches;
name = "${pname}-${version}";
sha256 = "...";
}
https://github.com/NixOS/nixpkgs/pull/144733/files#diff-a35bcf6b38716a31d2a5ea43b4ff2e6217c591817597572a22d560fa86ba0bb8R28
| 16:54:57 |
| Yureka (she/her) | should be the same thing | 16:55:00 |
| legendofmiracles | In reply to @legendofmiracles:matrix.org
I'll play around a bit, thanks for the hint I can't, my rust version is 1.55 but this program needs 1.56 | 17:03:26 |
| Yureka (she/her) | staging-next has 1.56 | 17:04:10 |
| Yureka (she/her) | it's in the binary cache | 17:05:14 |
| Yureka (she/her) | nix build -f "<nixpkgs>" rustc -I nixpkgs=https://github.com/nixos/nixpkgs/archive/staging-next.tar.gz
| 17:05:21 |
 jonringer | you can target staging-next. Should still be quick to review legendofmiracles | 17:07:35 |
| jonringer | if you're hacking within nixpkgs. git rebase --onto=origin/staging-next HEAD~ | 17:08:09 |
| jonringer | * if you're hacking within nixpkgs. git rebase --onto=origin/staging-next HEAD~1 | 17:08:14 |
| legendofmiracles | I’m currently packaging in my local dotfiles overlays | 17:08:15 |
| jonringer | Ah, nevermind then :( | 17:08:26 |
| legendofmiracles | Well, I did move it to nixpkgs now
Got it all working, but now I’m getting this error:
ab-street> error: failed to parse manifest at `/build/source/abstio/Cargo.toml`
ab-street> Caused by:
ab-street> feature `edition2021` is required
ab-street> consider adding `cargo-features = ["edition2021"]` to the manifest
ab-street> Traceback (most recent call last):
ab-street> File "/nix/store/bxlx1dy64ywk6spy265jm53qz3a45yc9-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 42, in <module>
ab-street> main()
ab-street> File "/nix/store/bxlx1dy64ywk6spy265jm53qz3a45yc9-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 17, in main
ab-street> assert list(data.keys()) == ["source"]
ab-street> AssertionError
| 20:30:36 |
| jonringer | you need a rust compile 1.56+ | 20:36:18 |
| jonringer | and the looks like Cargo.toml needs to be updated | 20:36:37 |
| legendofmiracles | This is happening in staging-next, but my version is still 1.52 | 20:37:06 |
| jonringer | which package? | 20:37:23 |
| legendofmiracles | rust | 20:37:30 |
| legendofmiracles | rustc, cargo, you name it | 20:37:38 |
| jonringer | [12:37:15] jon@nixos ~/projects/nixpkgs (staging-next)
$ nix-build -A rustc
/nix/store/449lmdsx8dv2q5fn4xbkxk51d4cg2zih-rustc-1.56.1
| 20:37:42 |
| jonringer | do you have an overlay? | 20:37:56 |
| legendofmiracles | Oh, I want forward with your suggestion and am doing it in tree now | 20:38:15 |
| legendofmiracles | * Oh, I went forward with your suggestion and am doing it in tree now | 20:38:24 |
| legendofmiracles | In reply to @jonringer:matrix.org
if you're hacking within nixpkgs. git rebase --onto=origin/staging-next HEAD~1 So it seem you are right, my rust version is still too old… But this command doesn’t do anything :confused: | 20:46:38 |
| legendofmiracles | Only merge conflicts | 20:49:42 |
