| 26 Jul 2025 |
 emily | we leave a TODO saying to do that and then forget about it | 09:57:49 |
| emily | (for bonus points you can prepare the follow-up immediately and label it waiting for branch-off) | 09:58:21 |
| emily | In reply to @emilazy:matrix.org
we leave a TODO saying to do that and then forget about it there's stuff in lib saying like drop me in 23.05 | 09:58:55 |
| emily | every time I see it I consider dropping it but I sort of want to see how long it can last | 09:59:24 |
| emily | like waiting to see if it'll grow mould or something | 09:59:47 |
 niklaskorz | the throw can just be removed entirely if we just check for the presence of an explicit args ? useFetchCargoVendor | 10:01:18 |
| niklaskorz | ah wait no | 10:01:23 |
| emily | that downgrades to a warning | 10:01:32 |
| niklaskorz | we wanted a warning | 10:01:26 |
| niklaskorz | not an error | 10:01:38 |
| emily | but it needs to be a throw because the FOD hash changed | 10:01:45 |
| niklaskorz | yeah right | 10:01:44 |
| emily | I mean we shipped the throw in 25.06 so it wouldn't be too bad to drop it | 10:02:05 |
| niklaskorz | but also they would get the warning in addition to the error | 10:02:14 |
| emily | but if we have the warning might as well keep both for one more cycle and drop together | 10:02:16 |
| niklaskorz | so I don’t think the error has to be reworded | 10:02:21 |
| emily | In reply to @niklaskorz:matrix.org
but also they would get the warning in addition to the error put the throw first using or | 10:02:26 |
| emily | throwIf (!(args.useFetchCargoVendor or true)) | 10:03:11 |
| emily | In reply to @niklaskorz:matrix.org
so I don’t think the error has to be reworded oh I see | 10:03:39 |
| emily | the throw will cause a back trace and stuff though | 10:03:54 |
| niklaskorz | no need to change the default value | 10:03:59 |
| emily | I'd feel better about having all the info there | 10:04:02 |
| emily | not a big deal though | 10:04:05 |
| emily | In reply to @niklaskorz:matrix.org
no need to change the default value I think the default value breaks ?? actually I guess it probably doesn't | 10:04:23 |
| emily | attrsets so weird | 10:04:28 |
| emily | anyway do whatever, it's all nitpicking :P | 10:04:40 |
| emily | even the warning is automated nitpicking 😆 | 10:04:56 |
| niklaskorz | nix-repl> ({ useFetchCargoVendor ? true } @ attrs: attrs ? useFetchCargoVendor) { }
false
nix-repl> ({ useFetchCargoVendor ? true } @ attrs: attrs ? useFetchCargoVendor) { useFetchCargoVendor = true; }
true
| 10:05:23 |
| emily | I'm not even sure we should ship it in the final release since it's probably annoying for users with epsilon benefit but meh | 10:05:25 |
| emily | right, because attrs is the unprocessed value. brain was just off for a second | 10:05:53 |
