19 Nov 2024 |
ghpzin | @crop Iirc it is only included in nightly toolchains even in rustup, so you need either of the 2 overlays with nightly: https://github.com/nix-community/fenix https://github.com/oxalica/rust-overlay Something like this: https://github.com/tweag/nix-remote-rust/blob/2daccaa44eaa6e684531996f0f01eb94d3f71d75/flake.nix#L25 | 05:17:32 |
crop | thank you @ghpzin | 05:20:52 |
crop | is it possible to mix toolchains? i don't need nightly for development. can i still use miri as the only thing from nightly? | 05:29:09 |
ghpzin | there is combine in fenix : https://github.com/nix-community/fenix/blob/e10ba121773f754a30d31b6163919a3e404a434f/README.md?plain=1#L145 and probably something similar in rust-overlay | 05:58:53 |
Gaétan Lepage | Let's say a rust package has build features [a, b, c, d].
I want to remove a .
Is my only option
buildNoDefaultFeatures = true;
buildFeatures = [ "b" "c" "d" ];
?
This seems quite flaky to me. There is no buildDisabledFeatures ? | 14:03:27 |
emily | no, Cargo does not support that | 14:04:05 |
emily | you can patch the line out of the Cargo.toml instead | 14:04:14 |
Gaétan Lepage | Would you recommend this over my approach ? | 14:04:58 |
emily | it avoids drift if the upstream defaults change at least | 14:05:31 |
Gaétan Lepage | Indeed. Thanks :) | 14:06:23 |
Austin Horstman | I did that with tabby when we were bumping it, too. Since their default features included building llama-cpp-server, which we already built in another derivation. | 14:18:23 |
Gaétan Lepage | Ok ! I asked for zellij: https://github.com/NixOS/nixpkgs/pull/357261 | 14:19:10 |
Austin Horstman | oooh, they bumped it already | 14:20:44 |
Austin Horstman | hoping it fixes a bunch of the weird issues we were seeing | 14:21:00 |
Morj | In reply to@glepage:matrix.org
Let's say a rust package has build features [a, b, c, d].
I want to remove a .
Is my only option
buildNoDefaultFeatures = true;
buildFeatures = [ "b" "c" "d" ];
?
This seems quite flaky to me. There is no buildDisabledFeatures ? Removing a default feature is a breaking semver change: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove-another - if I read it right. So you can rest safe until a major update | 14:21:46 |
Gaétan Lepage | Sure, but this doesn't prevent us from forgetting to check what upstream does and forget to add newly introduced default feature to our white-list, right ? | 14:24:51 |
Austin Horstman | I think the idea was that should only need to check it on breaking changes, if they actually follow semver properly. | 14:27:22 |
Austin Horstman | Although, they introduced a default in a patch version :P | 14:28:10 |
Morj | In reply to@glepage:matrix.org Sure, but this doesn't prevent us from forgetting to check what upstream does and forget to add newly introduced default feature to our white-list, right ? No it doesn't. But in general if you have a major version upgrade, you can't be sure that your code using it will still work. This situation is no different | 14:28:58 |
Austin Horstman | I guess, it's not a real breaking change since it preserves the default behavior | 14:29:01 |
Gaétan Lepage | In reply to @morj:morj.men No it doesn't. But in general if you have a major version upgrade, you can't be sure that your code using it will still work. This situation is no different Well, I would argue that the code I used in the PR can either:
- succesfully remove the
vendored_curl default feature
- fail (I used
--replace-fail )
I don't see how it could "silently do something different) | 14:30:14 |
Gaétan Lepage | * Well, I would argue that the code I used in the PR can either:
- succesfully remove the
vendored_curl default feature
- fail (I used
--replace-fail )
I don't see how it could "silently do something different" | 14:30:16 |
20 Nov 2024 |
| inayet removed their profile picture. | 00:59:16 |
| imadnyc changed their display name from dre to imadnyc. | 01:41:37 |
21 Nov 2024 |
| Robert Rose joined the room. | 13:22:19 |
22 Nov 2024 |
| Li-ion changed their profile picture. | 20:25:54 |
25 Nov 2024 |
Gaétan Lepage | Would it make sense to have a disabledTests attribute in buildRustPackages (similar to the one of buildPythonPackage ) ?
checkFlags = [
"--skip=foo::bar::baz"
"--skip=bonjour::au_revoir"
];
->
disabledTests = [
"foo::bar::baz"
"bonjour::au_revoir"
];
| 09:11:20 |
| NullCube joined the room. | 09:59:04 |
| tnias joined the room. | 23:08:17 |
26 Nov 2024 |
Toma | Would appreciate some feedback at https://github.com/NixOS/nixpkgs/pull/350541
also, related trivial fix: https://github.com/NixOS/nixpkgs/pull/359211 | 07:58:07 |