| 26 Jul 2025 |
 emily | In reply to @tomasajt:matrix.org
I will be away for a week, so I wont be able to handle this myself
But I'd say the warning PR should be like
`useFetchCargoVendor ? null` and `warnIf (useFetchCargoVendor != null) ......`
About whether we merge the main PR now: uuhhh, I'm leaning towards not wating for stable, but IDK
maybe args ? useFetchCargoVendor is better | 09:55:42 |
 Toma | That is better | 09:56:35 |
| emily | thanks for all the work you've done lately btw. try not to check notifications too much while you're away :) | 09:56:59 |
| emily | In reply to @emilazy:matrix.org
maybe args ? useFetchCargoVendor is better we will also need to reword the throw for the false case to just tell people to remove it | 09:57:24 |
 niklaskorz | "+1“ on that! | 09:57:24 |
| emily | and then after branch-off we drop 'em both | 09:57:35 |
| emily | or rather | 09:57:40 |
| emily | we leave a TODO saying to do that and then forget about it | 09:57:49 |
| emily | (for bonus points you can prepare the follow-up immediately and label it waiting for branch-off) | 09:58:21 |
| emily | In reply to @emilazy:matrix.org
we leave a TODO saying to do that and then forget about it there's stuff in lib saying like drop me in 23.05 | 09:58:55 |
| emily | every time I see it I consider dropping it but I sort of want to see how long it can last | 09:59:24 |
| emily | like waiting to see if it'll grow mould or something | 09:59:47 |
| niklaskorz | the throw can just be removed entirely if we just check for the presence of an explicit args ? useFetchCargoVendor | 10:01:18 |
| niklaskorz | ah wait no | 10:01:23 |
| emily | that downgrades to a warning | 10:01:32 |
| niklaskorz | we wanted a warning | 10:01:26 |
| niklaskorz | not an error | 10:01:38 |
| emily | but it needs to be a throw because the FOD hash changed | 10:01:45 |
| niklaskorz | yeah right | 10:01:44 |
| emily | I mean we shipped the throw in 25.06 so it wouldn't be too bad to drop it | 10:02:05 |
| niklaskorz | but also they would get the warning in addition to the error | 10:02:14 |
| emily | but if we have the warning might as well keep both for one more cycle and drop together | 10:02:16 |
| niklaskorz | so I don’t think the error has to be reworded | 10:02:21 |
| emily | In reply to @niklaskorz:matrix.org
but also they would get the warning in addition to the error put the throw first using or | 10:02:26 |
| emily | throwIf (!(args.useFetchCargoVendor or true)) | 10:03:11 |
| emily | In reply to @niklaskorz:matrix.org
so I don’t think the error has to be reworded oh I see | 10:03:39 |
| emily | the throw will cause a back trace and stuff though | 10:03:54 |
| niklaskorz | no need to change the default value | 10:03:59 |
| emily | I'd feel better about having all the info there | 10:04:02 |
| emily | not a big deal though | 10:04:05 |
