| 15 Jul 2025 |
 Toma | * With staging-next done, we can do https://github.com/NixOS/nixpkgs/pull/421558 now
This is just the removal of the usages, not the removal of the logic.
For the logic, should we make setting useFetchCargoVendor a warning/error in 25.11?
We could just remove the logic completely, but then people might not remove it from their out-of-tree derivations...
Or, since we didn't have too long of a period where useFetchCargoVendor was forced to be set to true manually, we should just remove it without warnings.
| 13:24:08 |
 emily | I'm ambivalent about warning vs. error, but I think we should have some notice rather than just an unknown argument error | 13:29:19 |
| emily | warning and then hard removal in 26.05 seems okay | 13:29:36 |
| emily | * warning in 25.11 and then hard removal in 26.05 seems okay | 13:29:39 |
| Toma | There are now unknown arguments... its just mkDerivation, anything goes | 13:29:48 |
| Toma | * There are no unknown arguments... its just mkDerivation, anything goes | 13:30:06 |
| emily | ouch… | 13:30:08 |
| emily | good point | 13:30:16 |
| emily | maybe a throw and then removal then | 13:30:36 |
| Toma | Also, should we wait for https://github.com/NixOS/nixpkgs/pull/423228 to reach stable so that we can do a double treewide to completely avoid merge conflicts? | 13:31:34 |
| Toma | * Also, should we wait for https://github.com/NixOS/nixpkgs/pull/423228 to reach stable so that we can do a double treewide to completely avoid backport merge conflicts? | 13:32:04 |
| emily | probably let's wait | 13:32:40 |
| Toma | alright | 13:33:05 |
| emily | probably not a big deal | 13:33:25 |
| emily | but means we can handle all the conflicts at once | 13:33:30 |
| emily | likely we'll need to deal with the staging branches too | 13:33:38 |
| emily | you have commit bit for that right? | 13:33:44 |
| Toma | I have not touched staging manually yet... | 13:35:50 |
| emily | it's pretty much just git merge, resolve conflicts, push | 13:36:52 |
| emily | but it is scary :P | 13:36:53 |
| emily | Toma: FWIW it seems nitpicking of useless useFetchCargoVendor = true; in PRs is a thing already | 15:34:36 |
| emily | so I definitely think we should warn or throw for a version so that CI can handle that | 15:34:45 |
| emily | (both work since warnings are forbidden in Nixpkgs) | 15:34:54 |
|  nyanbinary 🏳️⚧️ removed their profile picture. | 22:12:12 |
|  ginkogruen joined the room. | 22:52:22 |
| 16 Jul 2025 |
|  cods joined the room. | 13:47:42 |
|  @poacher:unredacted.org joined the room. | 15:36:55 |
| 17 Jul 2025 |
| nyanbinary 🏳️⚧️ set a profile picture. | 01:27:34 |
|  @zeromute:matrix.org left the room. | 04:52:44 |
|  @c0d3h01:matrix.org left the room. | 10:04:06 |
