3 Sep 2024 |
K900 | Just need to throw a showAttrPath on there | 14:04:47 |
Alyssa Ross | Yeah | 14:04:50 |
Alyssa Ross | Commented version must have predated them being nested | 14:05:02 |
Alyssa Ross | I didn't know showAttrPath
| 14:05:18 |
Alyssa Ross | Are you fixing it or should I? | 14:05:36 |
K900 | Just did | 14:06:07 |
K900 | https://github.com/NixOS/nixpkgs/pull/339253 | 14:06:07 |
K900 | And now to figure out what's actually calling it | 14:07:40 |
K900 | ecks dee | 14:07:42 |
K900 | https://github.com/nix-community/fenix/blob/main/default.nix#L28 | 14:09:25 |
K900 | It's fenix | 14:09:27 |
K900 | Ping @figsoda | 14:10:42 |
emily | https://github.com/NixOS/nixpkgs/pull/339281 | 16:13:17 |
Alyssa Ross | Have we verified we're not breaking FODs this time? | 16:20:18 |
emily | I haven't verified it, and I don't know if the PR author has :) | 16:22:05 |
Alyssa Ross | (Last time: https://github.com/NixOS/nixpkgs/pull/321095) | 16:22:11 |
emily | just wanted to link it here to publicize | 16:22:13 |
emily | I'll link that | 16:22:20 |
Alyssa Ross | I can do it? | 16:22:26 |
emily | ah, sorry | 16:23:05 |
emily | I already wrote the comment | 16:23:08 |
emily | (didn't mean to step on your toes) | 16:23:25 |
Alyssa Ross | no worries | 16:24:00 |
emily | FWIW it doesn't look like it's doing anything fancier than last time so I expect it'll break things | 16:24:03 |
emily | we can probably move the file in the build hook instead, I'm assuming? | 16:24:40 |
Alyssa Ross | Looks like the other PR this one is a dupe of has been tested properly | 16:24:43 |
Alyssa Ross | Maybe we should just merge that one? | 16:24:46 |
emily | aha | 16:25:03 |
emily | the dupe looks better if we don't care about pre-2019 Rust versions | 16:25:31 |
Alyssa Ross | Other PR looks very reasonable, as it doesn't touch fetchCargoTarball at all. | 16:25:35 |