| 10 Aug 2024 |
|  Austin Horstman changed their display name from Khaneliman to Austin Horstman. | 03:50:05 |
|  blitz changed their display name from Julian Stecklina to blitz. | 08:01:31 |
 emily | could use some eyes on https://github.com/NixOS/nixpkgs/pull/332809 to make sure rustup doesn't break on unstable soon | 13:55:12 |
| emily | we have a bizarre x86_64-linux-only (not even aarch64-linux!) build failure about missing test modules / cfg(test) that has been bisected to a PR that touches 73 files | 13:55:40 |
|  Fraol Lemecha joined the room. | 14:18:25 |
 ghpzin | checkFeatures = [ "test" ]; does not work ? | 14:26:15 |
| ghpzin | * emily:
checkFeatures = [ "test" ]; does not work ? | 14:27:34 |
| emily | 🤔 | 14:27:43 |
| emily | maybe it's that simple? but surely that would already be default? | 14:27:52 |
| emily | does this relate to the Nixpkgs thing of building tests against the release library? it doesn't seem like any other package sets checkFeatures = [ "test" ]; | 14:28:46 |
| ghpzin | It's a feature rustup added in that PR Alyssa bisected failure to. | 14:29:22 |
| ghpzin | * It's a feature rustup added in that PR Alyssa bisected failure to.
It is called "test" and not included in default features. | 14:29:49 |
| ghpzin | * It's a feature rustup added in that PR Alyssa bisected failure to.
It is called "test" and not included in default features.
Unless I misread, they just added it to all their CI, ie:
cargo check --all --all-targets --features test | 14:30:41 |
| emily | right, that makes sense. isn't there a feature set on by default for test builds though? oh, I guess that's #[cfg(tests)]? confusing… | 14:31:55 |
