!FBuJyWXTGcGtHTPphC:nixos.org

Nix Rust

695 Members
Rust157 Servers

Load older messages


SenderMessageTime
22 May 2025
@emilazy:matrix.orgemily Alyssa Ross: do you have a preference between the diffs of https://github.com/NixOS/nixpkgs/pull/408710/files and https://github.com/NixOS/nixpkgs/pull/407790/files? they both fix pkgsStatic.buildPackages.rustc on Darwin, and they'll both leave some other cases unavoidably silently weird/broken (I think maybe slightly different cases between them). the original PR no longer depends on pkgsStatic. it's a bit more noisy but saves a rustc build. the other one is a smaller diff / fewer moving parts, but the ordering change is sort of unprincipled (albeit I think likely to make the build go through in strictly more cases than the status quo) 09:02:30
@qyliss:fairydust.spaceAlyssa RossI don't think I mind either09:06:36
@qyliss:fairydust.spaceAlyssa RossI'd still really like to see the custom target specs eventually09:06:50
@qyliss:fairydust.spaceAlyssa RossConsider them both acked09:06:59
@emilazy:matrix.orgemilyme too, but cleaning up Rust is more work than I have the capacity for right now :(09:08:32
@emilazy:matrix.orgemily honestly we should really build std in a separate derivation always, I think 09:08:40
@emilazy:matrix.orgemilyand with the right platform triples09:08:43
@emilazy:matrix.orgemily rather than building a "rustc" that is actually just the target platform std 09:08:54
@qyliss:fairydust.spaceAlyssa Ross IIRC @Ericson2314:matrix.org didn't think it was possible some time in the past 09:10:08
@emilazy:matrix.orgemily why not? it's exactly what fastCross does, right? 09:11:25
@emilazy:matrix.orgemily like fastCross could just not link in the rustc in installation phase, and swizzle around the targets that it passes, and then we could wrap them together later 09:12:09
@emilazy:matrix.orgemily I guess the problem is that the non-cross compiler would still want to build the target std 09:12:28
@emilazy:matrix.orgemily -Zbuild-std at least helps… 09:12:39
@k900:0upti.meK900One day we'll have cargo-std-aware09:13:08
@emilazy:matrix.orgemily patch Rust to accept -Zbuild-std on stable, do separate-Rust-crate-packaging, make std one of them 🙃 09:13:14
@k900:0upti.meK900One day09:13:15
@emilazy:matrix.orgemily it'll be awful with the current Rust packaging scheme. because we would build std for every single application 09:13:38
@emilazy:matrix.orgemily oh, I guess not because the FOD is compressed, right? Toma: why do we compress the FOD again? 12:08:43
@emilazy:matrix.orgemilyanyway, maybe we could move the unpacking of the FOD into the actual Rust package build?12:08:54
@qyliss:fairydust.spaceAlyssa RossWe'd need to do fetchCargoVendor2 for that12:13:56
@tomasajt:matrix.orgTomaIt is compressed, because it is how they are downloaded, and it is also not uncompressed so that we don't have file system case sensitiveness bite us with different hashes12:13:59
@qyliss:fairydust.spaceAlyssa Ross(Which doesn't mean we shouldn't)12:14:06
@qyliss:fairydust.spaceAlyssa Rossah right12:14:12
@emilazy:matrix.orgemilyfair12:16:26
@tomasajt:matrix.orgToma
In reply to @tomasajt:matrix.org
It is compressed, because it is how they are downloaded, and it is also not uncompressed so that we don't have file system case sensitiveness bite us with different hashes
Also, just in general, the goal was to have the dumbest possible FOD logic so that under no circumstance will the hash break.
12:16:29
@emilazy:matrix.orgemilyI think moving it into a hook of the actual build would be good?12:16:35
@emilazy:matrix.orgemilythat way nothing gets persisted12:16:47
@tomasajt:matrix.orgTomaIt would be better. Though we'd need some interesting workarounds... An interesting option would be to have the non-FOD part jus be a directory with a symlink to the FOD and a marker file that the hook can detect.12:19:40
@tomasajt:matrix.orgToma* It would be better. Though we'd need some interesting workarounds... An interesting option would be to have the non-FOD part just be a directory with a symlink to the FOD and a marker file that the hook can detect.12:19:59
@tomasajt:matrix.orgTomaIdeally we'd get rid of the double layering, but I don't know how viable that is really at this point... (It's not backportable, there are no marker files in the FOD part, except maybe the way the directories were named)12:22:39

Show newer messages


Back to Room ListRoom Version: 6