!FBuJyWXTGcGtHTPphC:nixos.org

Nix Rust

687 Members
Rust155 Servers

Load older messages


SenderMessageTime
25 Mar 2025
@emilazy:matrix.orgemilyso maybe it is not a good idea, even if it is better for Nixpkgs14:14:32
@tomasajt:matrix.orgTomabtw we're still using replace-workspace-values.py in fetchCargoVendor14:14:42
@emilazy:matrix.orgemilyyeah I saw :)14:14:48
@emilazy:matrix.orgemilyanyway, ok, this is a distraction. if we want to do that we can do it another release anyway14:15:16
@emilazy:matrix.orgemilybut I think we should do this now before we forget :P14:15:26
@emilazy:matrix.orgemily I'm reproducing system-syzygy before merging 14:15:38
@emilazy:matrix.orgemily fwiw, the thing about supporting old lock files isn't so much about existing packages but the fact that I find it hard to imagine a PR to add a new one that we'd want to accept 14:19:04
@emilazy:matrix.orgemily so given the existence of a fallback path in the form of importCargoLock it seems bad to add any complexity to our current infrastructure for it 14:19:31
@tomasajt:matrix.orgTomayeah, not worth rebuilding so many packages for those14:24:01
@tomasajt:matrix.orgTomaI know i've already sent this in a few times, but: https://github.com/NixOS/nixpkgs/pull/39017114:25:49
@emilazy:matrix.orgemilynot sure I understand this PR enough to approve it without reading up more on the issue14:27:52
@emilazy:matrix.orgemily Toma: are you up for doing this or would you like me to have a go at it? 15:13:08
@tomasajt:matrix.orgTomaI will be away thursday-sunday when I won't really be able to respond, so I'd appreciate if someone else did it15:14:19
@marie:marie.cologneMarie changed their display name from Marie to Marie Ramlow.17:42:02
@marie:marie.cologneMarie changed their display name from Marie Ramlow to Marie.17:44:37
@djacu:matrix.orgdjacu

What's the desired avenue for discussing and submitting problems found within rustPlatform? I have found a few issues when dealing with private registries. I can provide more complete details but I'll share a short summary for now.

  1. The fetchCrate function in import-cargo-lock.nix assumes that all registry platforms follow the same URL path schema. Sadly not all do and some don't even expose tar.gz files. I have a fix that changes how the function works so users must define the url path, naming scheme, etc.
  2. The mkCrate function generally works for private registries, but it will not work for git dependencies that have a dependency in a private registry. In the beginning of the runCommand instructions are two calls to cargo metadata that are pointed at the source Cargo.toml but will not find the .cargo/config.toml and therefore cannot find information about the registry-index.
18:05:21
@djacu:matrix.orgdjacu *

What's the desired avenue for discussing and submitting problems/fixes found within rustPlatform? I have found a few issues when dealing with private registries. I can provide more complete details but I'll share a short summary for now.

  1. The fetchCrate function in import-cargo-lock.nix assumes that all registry platforms follow the same URL path schema. Sadly not all do and some don't even expose tar.gz files. I have a fix that changes how the function works so users must define the url path, naming scheme, etc.
  2. The mkCrate function generally works for private registries, but it will not work for git dependencies that have a dependency in a private registry. In the beginning of the runCommand instructions are two calls to cargo metadata that are pointed at the source Cargo.toml but will not find the .cargo/config.toml and therefore cannot find information about the registry-index.
18:05:32
@tomasajt:matrix.orgToma

IMO opening an nixpkgs issue with some details is fine

btw I had a TODO for fetchCargoVendor to add a way to deduce the download URL schema from the registry url.
I think there is some dl key that can be fetched through some API.

(but first we have to figure out how under what directory should we store files fetched from non-standard registries)

19:01:23
@djacu:matrix.orgdjacuInteresting. Is there a list of TODOs posted somewhere or an issue with a collection of desired improvements? I'd be happy to at least take a look at it. Also, issue posted here with more details https://github.com/NixOS/nixpkgs/issues/39321722:17:29
@tomasajt:matrix.orgTomasome TODOs are listed in fetch-cargo-vendor-util.py22:18:42
@tomasajt:matrix.orgTomabtw I might be wrong but aren't .crate files .tar.gz files just with a different extension?22:20:44
@djacu:matrix.orgdjacuyes22:58:32
26 Mar 2025
@hive:the-apothecary.club👉@crystallinefire:chat.solarpunk.moe changed their profile picture.03:50:43
@sergey:shishkin.orgsergey joined the room.14:20:30
@hive:the-apothecary.club👉@crystallinefire:chat.solarpunk.moe changed their profile picture.19:29:00
27 Mar 2025
@sergey:shishkin.orgsergey left the room.08:38:48
28 Mar 2025
@emilazy:matrix.orgemilydone https://github.com/NixOS/nixpkgs/pull/39401213:58:20
@fxomt:pub.solar@fxomt:pub.solar joined the room.14:17:40
@scottytheengineer:matrix.orgscottytheengineer joined the room.18:16:10
@nakibrayane:matrix.orgRayane Nakib (ريّان نقيب) changed their display name from Rayane Nakib (ريان نقيب) to Rayane Nakib (ريّان نقيب).22:51:54

Show newer messages


Back to Room ListRoom Version: 6