| 12 Mar 2023 |
| @thetapo:matrix.org removed their display name TheTapo. | 07:50:19 |
| @thetapo:matrix.org left the room. | 07:50:50 |
| 13 Mar 2023 |
| @rasmus:rend.al joined the room. | 08:42:51 |
hexa | apparently the next go release is going to be reproducible https://github.com/golang/go/issues/57120 | 17:23:36 |
hexa | shared by fox/boron 🙂 | 17:23:55 |
j-k | might also be of interest: https://github.com/golang/go/issues/54265
c build -> go 1.4 -> 1.17.13 -> 1.20 -> 1.22 | 17:25:57 |
| @rimuru:gentoo.chat changed their profile picture. | 23:25:35 |
| 15 Mar 2023 |
| raitobezarius joined the room. | 14:28:02 |
| 16 Mar 2023 |
| Chris Guest joined the room. | 23:26:39 |
| 18 Mar 2023 |
raitobezarius | Hello there, I would like to split the diffoscope package into 3 flavors: diffoscopeMinimal, diffoscope, diffoscopeUnfree because currently diffoscope requires unfree dependencies and this is surprising, is it okay if I send a PR regarding that? | 15:00:02 |
atemu12 | Sure, sounds good | 15:00:46 |
Alyssa Ross | Do we need three different options? | 15:01:38 |
Alyssa Ross | Why do we need an attribute for the unfree one when it can't be built by Hydra anyway? | 15:01:52 |
raitobezarius | Good point | 15:02:09 |
Alyssa Ross | Just make it a package option imo | 15:02:10 |
raitobezarius | I'm adding enableUnfree anyway to the signature | 15:02:22 |
raitobezarius | I can just skip diffoscopeUnfree | 15:02:26 |
Alyssa Ross | Yeah | 15:02:28 |
Alyssa Ross | While you're at it, might be good to flip the default of enableBloat, because it's pretty confusing to see it default to false in the package, but then have it overridden to true in the diffoscope callPackage | 15:03:09 |
raitobezarius | got it | 15:03:22 |
raitobezarius | Alyssa Ross: hm it's more complicated | 15:06:20 |
raitobezarius | diffoscopeMinimal = callPackage ../ { jdk = jdk8; } | 15:06:33 |
raitobezarius | diffoscope = diffoscopeMinimal.override { enableBloat = true; } | 15:06:41 |
raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDawrin; } | 15:06:45 |
raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDarwin; } | 15:06:48 |
raitobezarius | so would you say I move the stdenv.isDarwin to the derivation? | 15:06:55 |
Alyssa Ross | yes | 15:07:03 |
raitobezarius | okay | 15:07:13 |
Alyssa Ross | And have diffoscopeMinimal override diffoscope instead. | 15:07:16 |
raitobezarius | got it | 15:07:22 |