| 18 Mar 2023 |
 atemu12 | Sure, sounds good | 15:00:46 |
 Alyssa Ross | Do we need three different options? | 15:01:38 |
| Alyssa Ross | Why do we need an attribute for the unfree one when it can't be built by Hydra anyway? | 15:01:52 |
 raitobezarius | Good point | 15:02:09 |
| Alyssa Ross | Just make it a package option imo | 15:02:10 |
| raitobezarius | I'm adding enableUnfree anyway to the signature | 15:02:22 |
| raitobezarius | I can just skip diffoscopeUnfree | 15:02:26 |
| Alyssa Ross | Yeah | 15:02:28 |
| Alyssa Ross | While you're at it, might be good to flip the default of enableBloat, because it's pretty confusing to see it default to false in the package, but then have it overridden to true in the diffoscope callPackage | 15:03:09 |
| raitobezarius | got it | 15:03:22 |
| raitobezarius | Alyssa Ross: hm it's more complicated | 15:06:20 |
| raitobezarius | diffoscopeMinimal = callPackage ../ { jdk = jdk8; } | 15:06:33 |
| raitobezarius | diffoscope = diffoscopeMinimal.override { enableBloat = true; } | 15:06:41 |
| raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDawrin; } | 15:06:45 |
| raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDarwin; } | 15:06:48 |
| raitobezarius | so would you say I move the stdenv.isDarwin to the derivation? | 15:06:55 |
| Alyssa Ross | yes | 15:07:03 |
| raitobezarius | okay | 15:07:13 |
| Alyssa Ross | And have diffoscopeMinimal override diffoscope instead. | 15:07:16 |
| raitobezarius | got it | 15:07:22 |
| raitobezarius | is there a good way to test if a package is unfree also? | 15:08:36 |
| raitobezarius | like I can write the filterUnfree function with examining pkg.meta.license(s).free parameter | 15:08:50 |
| raitobezarius | just wondering if there was a better way | 15:08:57 |
| Alyssa Ross | You can, but it's probably best not to. | 15:09:00 |
| raitobezarius | you would rather have it as a human-written set of unfree packages? | 15:09:14 |
| raitobezarius | okay | 15:09:15 |
| Alyssa Ross | Yeah | 15:09:19 |
| Alyssa Ross | Stuff shouldn't change from free to unfree often. | 15:09:26 |
| Alyssa Ross | and if you start doing it automatically you end up in a can of worms relating to whether you should vary behaviour based on allowUnfree / allowUnfreePredicate | 15:09:59 |
| raitobezarius | https://github.com/NixOS/nixpkgs/pull/221861 | 15:14:00 |
