| 5 May 2023 |
 raboof | For the ISO's there is a nice final check of actually rebuilding the iso on an ancient nixos version without substituters 😃. | 20:24:50 |
 baloo | In reply to @delroth:delroth.net
I have experience with teams accidentally carving out a metric that doesn't actually cover the whole problem they want to solve, get the metric to the desired goal, then declare victory too early :) it's a pretty common pattern Not that I disagree with the point, but ... having small victories along the way helps a ton with moral. | 20:25:08 |
 GenericNerdyUsername | In reply to @raboof:matrix.org
For the ISO's there is a nice final check of actually rebuilding the iso on an ancient nixos version without substituters 😃. why not just use --offline? | 20:25:17 |
 delroth | In reply to @baloo_:matrix.org
Not that I disagree with the point, but ... having small victories along the way helps a ton with moral. oh absolutely, but if that's the goal you could just do a filter which hides 50% of the unreproducible targets at random and focus on that :P my main concern isn't having "partial" milestones, it's that it's not clear to me how much the set that was picked actually reflects its goal (no build packages, but all host packages that get shipped to the user) | 20:27:18 |
| baloo | fair | 20:27:47 |
| baloo | keep in mind the end goal I guess. But I won't diminish the value of compromises. | 20:28:22 |
| delroth | my tribute to the reproducibility gods in exchange for this discussion: https://github.com/NixOS/nixpkgs/pull/230186 and https://github.com/google/libphonenumber/pull/2921 (to be backported if it gets merged)
(Trying to keep my nitpicking / contributions ratio < 1 :P) | 21:07:39 |
| 6 May 2023 |
| GenericNerdyUsername | im working on fixing the gegl unreprodicibility, should I use sed or a tool dedicated to xml? I dont want to increase the closure size just for some text substitution, but i dont want it to break every update | 23:35:49 |
| 7 May 2023 |
| GenericNerdyUsername | went for patching the source instead | 00:56:54 |
| GenericNerdyUsername | https://github.com/NixOS/nixpkgs/pull/230429 | 01:04:36 |
|  @lotte:chir.rs joined the room. | 07:41:00 |
 @rnhmjoj:maxwell.ydns.eu | if anyone wants to make a PR the libnvme issue seems to be fixed with just:
--- a/pkgs/os-specific/linux/libnvme/default.nix
+++ b/pkgs/os-specific/linux/libnvme/default.nix
@@ -50,7 +50,7 @@ stdenv.mkDerivation rec {
mesonFlags = [
"-Ddocs=man"
- "-Ddocs-build=true"
+ "-Ddocs-build=false"
];
doCheck = true;
| 08:19:25 |
| @rnhmjoj:maxwell.ydns.eu | * if anyone wants to make a PR, the libnvme issue seems to be fixed with just:
--- a/pkgs/os-specific/linux/libnvme/default.nix
+++ b/pkgs/os-specific/linux/libnvme/default.nix
@@ -50,7 +50,7 @@ stdenv.mkDerivation rec {
mesonFlags = [
"-Ddocs=man"
- "-Ddocs-build=true"
+ "-Ddocs-build=false"
];
doCheck = true;
| 08:19:32 |
| delroth | that's more of a workaround than a fix... having the docs built would probably still be desirable | 19:56:00 |
| delroth | ah nvm, I misunderstood -- looks like -Ddocs-build=false just uses pre-built manpages bundled in the source repo | 19:58:56 |
| delroth | but I think libnvme is already fixed anyway by using the source epoch? | 19:59:10 |
| 8 May 2023 |
| @rnhmjoj:maxwell.ydns.eu | I think so, but it's quite useless upstream stops bundling the manual pages | 05:50:34 |
