| 18 Mar 2023 |
 raitobezarius | Alyssa Ross: hm it's more complicated | 15:06:20 |
| raitobezarius | diffoscopeMinimal = callPackage ../ { jdk = jdk8; } | 15:06:33 |
| raitobezarius | diffoscope = diffoscopeMinimal.override { enableBloat = true; } | 15:06:41 |
| raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDawrin; } | 15:06:45 |
| raitobezarius | * diffoscope = diffoscopeMinimal.override { enableBloat = !stdenv.isDarwin; } | 15:06:48 |
| raitobezarius | so would you say I move the stdenv.isDarwin to the derivation? | 15:06:55 |
 Alyssa Ross | yes | 15:07:03 |
| raitobezarius | okay | 15:07:13 |
| Alyssa Ross | And have diffoscopeMinimal override diffoscope instead. | 15:07:16 |
| raitobezarius | got it | 15:07:22 |
| raitobezarius | is there a good way to test if a package is unfree also? | 15:08:36 |
| raitobezarius | like I can write the filterUnfree function with examining pkg.meta.license(s).free parameter | 15:08:50 |
| raitobezarius | just wondering if there was a better way | 15:08:57 |
| Alyssa Ross | You can, but it's probably best not to. | 15:09:00 |
| raitobezarius | you would rather have it as a human-written set of unfree packages? | 15:09:14 |
| raitobezarius | okay | 15:09:15 |
| Alyssa Ross | Yeah | 15:09:19 |
| Alyssa Ross | Stuff shouldn't change from free to unfree often. | 15:09:26 |
| Alyssa Ross | and if you start doing it automatically you end up in a can of worms relating to whether you should vary behaviour based on allowUnfree / allowUnfreePredicate | 15:09:59 |
| raitobezarius | https://github.com/NixOS/nixpkgs/pull/221861 | 15:14:00 |
| 19 Mar 2023 |
|  quasineutral joined the room. | 11:42:13 |
| 21 Mar 2023 |
 davidak | In reply to @qyliss:fairydust.space
and if you start doing it automatically you end up in a can of worms relating to whether you should vary behaviour based on allowUnfree / allowUnfreePredicate i think you should and created an issue for the Nixpkgs Architecture Team to discuss it https://github.com/nixpkgs-architecture/issues/issues/18 | 19:04:14 |
| davidak | but i wouldn't block the PR for that. enableUnfree is commonly used already | 19:05:17 |
| 22 Mar 2023 |
 Rick (Mindavi) | What is unfree in diffoscope? I cannot recall I ran into that ... | 15:14:18 |
| Alyssa Ross | apk-tool depends on something unfree | 15:15:29 |
| Alyssa Ross | I assume the pre-compiled android sdk | 15:15:33 |
 atemu12 | If it's just the tools, you could probably wire up our free build | 15:15:54 |
 raboof | (https://github.com/NixOS/nixpkgs/pull/208793) | 15:16:05 |
| Alyssa Ross | omg cool | 15:20:06 |
| Rick (Mindavi) | Mmm, not sure why I haven't run into that | 15:28:28 |
