!LemuOOvbWqRXodtSsw:nixos.org

NixOS Reproducible Builds

531 Members
Report: https://reproducible.nixos.org Project progress: https://github.com/orgs/NixOS/projects/30122 Servers

Load older messages


SenderMessageTime
31 Oct 2025
@pyrox:pyrox.devdish [Fox/It/She] I'm wondering if it would be reasonable to disable the checkPhase in writeShellApplication for pre-switch-checks, which is the only user of haskell in the default system closure. While having shellcheck is a good idea, system.preSwitchChecks is only used in two repos outside of nixpkgs(according to a quick sourcegraph search), and I feel like if this is something you're using, you're generally better at shell scripting and don't need to worry as much about shellcheck. Just a thought though, and would allow us to cut off the entire ghc repro issue for minmal isos 19:00:34
@pyrox:pyrox.devdish [Fox/It/She] I'm wondering if it would be reasonable to disable the checkPhase in writeShellApplication for pre-switch-checks, which is the only user of haskell in the default system closure. While having shellcheck is a good idea, system.preSwitchChecks is only used in two repos outside of nixpkgs(according to a quick sourcegraph search), and I feel like if this is something you're using, you're generally better at shell scripting and don't need to worry as much about shellcheck. Just a thought though, and would allow us to cut off the entire ghc/haskell repro issue for minmal isos 19:00:40
@emilazy:matrix.orgemilyhow much would that shrink the minimal ISO?22:26:25
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)it would save me annoying ghc compiles on my minimalism adventures, i approve22:26:55
@emilazy:matrix.orgemily I am frankly not sure we need preSwitchChecks at all 22:27:23
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) Do we use buildShellApplication outside systemd.enableStrictShellChecks = true in the default closure? 22:27:57
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)actually wait no that is false by default huh22:28:25
@emilazy:matrix.orgemily
          --set PRE_SWITCH_CHECK ${lib.escapeShellArg config.system.preSwitchChecksScript} \
22:29:56
@emilazy:matrix.orgemily I think we actually just need to conditionalize this on config.system.preSwitchChecks22:30:19
@emilazy:matrix.orgemily the same way it is in nixos/modules/system/activation/top-level.nix 22:30:24
@emilazy:matrix.orgemilypretty funny if this pulled GHC into the build closure of every switchable system and nobody noticed, though that sounds too good to be true22:31:01
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)no, that sounds about reasonable22:31:18
@raboof:matrix.orgraboof
In reply to @emilazy:matrix.org
how much would that shrink the minimal ISO?
Afaics not, it's just a build-time dependency right?
22:31:24
@emilazy:matrix.orgemilyright22:31:30
@emilazy:matrix.orgemilystill seems good to avoid.22:31:46
@emilazy:matrix.orgemilyit's a one-liner fix22:31:52
@raboof:matrix.orgraboofYeah. I thought it was used in more places though, but afk now22:33:04
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)looking at my musl experiments, it is literally JUST pre-switch-checks depending on ghc22:33:42
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) https://termbin.com/hala
nix why-depends --derivation --all .#nixosConfigurations.grimm-musl.config.system.build.toplevel .#nixosConfigurations.grimm-musl.pkgs.ghc
22:34:41
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)i didn't check whether there might be more ghc on the way to qemu, but toplevel is what counts22:35:25
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)this is minimal+perlless+musl+some bashless, but it is a graphical switchable system22:35:58
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)* this is minimal+perlless+musl+some bash reduction, but it is a graphical switchable system22:36:11
@emilazy:matrix.orgemily what we really want is a passthru.tests for NixOS configs 22:37:38
@emilazy:matrix.orgemilythat can do all the ShellCheck stuff22:37:46
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)and udev checks too!22:38:32
@elvishjerricco:matrix.orgElvishJerricco joined the room.22:46:56
@elvishjerricco:matrix.orgElvishJerricco a default nixos config, including the ISO, already depends on ShellCheck because of nixos-firewall-tool, FYI 22:58:59
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)not minimal tho22:59:46
@elvishjerricco:matrix.orgElvishJerriccoyes minimal?22:59:53
@elvishjerricco:matrix.orgElvishJerriccoI just checked22:59:58

Show newer messages


Back to Room ListRoom Version: 6