| 26 Aug 2024 |
adisbladis | In reply to @emilazy:matrix.org although I don't know if anyone has actually decided what we support for Linux lol Using the version of linuxHeaders would make sense there I think | 02:31:38 |
emily | sounds reasonable. and for macOS, apple-sdk (when it exists in a few weeks) | 02:32:00 |
emily | though actually you want the darwinMinVersion I guess | 02:32:15 |
emily | and for other platforms, ??? | 02:32:22 |
adisbladis | In reply to @emilazy:matrix.org and for other platforms, ??? I'm inclined to set it to an empty string on those and let the hook fail loudly | 02:32:49 |
adisbladis | It will only fail for builds which reference platform_release | 02:33:00 |
emily | I take it setting it to an empty string in general isn't viable? | 02:33:06 |
adisbladis | And if we can't do something correct we might as well fail | 02:33:17 |
adisbladis | In reply to @emilazy:matrix.org I take it setting it to an empty string in general isn't viable? No. That was my initial attempt but that trips up the version parser | 02:33:34 |
emily | right | 02:33:47 |
emily | IMO, platforms should actually expose this information | 02:33:59 |
emily | the "minimum supported version of the platform" | 02:34:04 |
emily | rather than Python stuff having to figure it out | 02:34:15 |
Alyssa Ross | We have a fake uname package | 08:31:48 |
Alyssa Ross | Although I think here setting it to linuxHeaders.version probably makes sense. | 08:32:15 |
emily | what does that one output? :) | 14:10:54 |
emily | we should align them in any case | 14:10:58 |
emily | and add a fake sw_vers to match, that came up recently | 14:11:04 |
Alyssa Ross | I don't know. tbh I'm not a fan. | 14:27:44 |