| 6 May 2023 |
@genericnerdyusername:matrix.org | im working on fixing the gegl unreprodicibility, should I use sed or a tool dedicated to xml? I dont want to increase the closure size just for some text substitution, but i dont want it to break every update | 23:35:49 |
| 7 May 2023 |
@genericnerdyusername:matrix.org | went for patching the source instead | 00:56:54 |
@genericnerdyusername:matrix.org | https://github.com/NixOS/nixpkgs/pull/230429 | 01:04:36 |
| @lotte:chir.rs joined the room. | 07:41:00 |
@rnhmjoj:maxwell.ydns.eu | if anyone wants to make a PR the libnvme issue seems to be fixed with just:
--- a/pkgs/os-specific/linux/libnvme/default.nix
+++ b/pkgs/os-specific/linux/libnvme/default.nix
@@ -50,7 +50,7 @@ stdenv.mkDerivation rec {
mesonFlags = [
"-Ddocs=man"
- "-Ddocs-build=true"
+ "-Ddocs-build=false"
];
doCheck = true;
| 08:19:25 |
@rnhmjoj:maxwell.ydns.eu | * if anyone wants to make a PR, the libnvme issue seems to be fixed with just:
--- a/pkgs/os-specific/linux/libnvme/default.nix
+++ b/pkgs/os-specific/linux/libnvme/default.nix
@@ -50,7 +50,7 @@ stdenv.mkDerivation rec {
mesonFlags = [
"-Ddocs=man"
- "-Ddocs-build=true"
+ "-Ddocs-build=false"
];
doCheck = true;
| 08:19:32 |
delroth | that's more of a workaround than a fix... having the docs built would probably still be desirable | 19:56:00 |
delroth | ah nvm, I misunderstood -- looks like -Ddocs-build=false just uses pre-built manpages bundled in the source repo | 19:58:56 |
delroth | but I think libnvme is already fixed anyway by using the source epoch? | 19:59:10 |
| 8 May 2023 |
@rnhmjoj:maxwell.ydns.eu | I think so, but it's quite useless upstream stops bundling the manual pages | 05:50:34 |