!MthpOIxqJhTgrMNxDS:nixos.org

NixOS ACME / LetsEncrypt

117 Members
Another day, another cert renewal48 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
30 May 2021
@hexa:lossy.networkhexa * Needs to come with a changelog entry either way. And to be fair, it is currently unnecessarily hard to drop the option.14:40:24
@hexa:lossy.networkhexa * Needs to come with a changelog entry either way. And to be fair, it is currently unnecessarily hard to drop the option if you needed to.14:40:30
@m1cr0man:m1cr0man.comm1cr0man
In reply to @hexa:lossy.network
Needs to come with a changelog entry either way. And to be fair, it is currently unnecessarily hard to drop the option if you needed to.
On the logic alone of "It's hard to change" I think it makes sense to merge it. But yes, with a changelog
14:44:03
@arianvp:matrix.orgArian joined the room.14:48:40
@m1cr0man:m1cr0man.comm1cr0manHi Arian :)14:50:05
@hexa:lossy.networkhexathe remaining question would be: backport to 21.05 or not?14:51:02
@hexa:lossy.networkhexaand by that matter: to which changelog to add this14:51:49
@m1cr0man:m1cr0man.comm1cr0manWould you not just add to 21.05 changelog when making the backport commit/PR?15:56:51
@hexa:lossy.networkhexaneeds to go into only one changelog though16:04:57
@hexa:lossy.networkhexaso either backport to 21.05, then add it there16:05:06
@hexa:lossy.networkhexaor keep it for 21.1116:05:13
@hexa:lossy.networkhexashould be part of the changelog were it was first introduced to endusers16:05:23
@m1cr0man:m1cr0man.comm1cr0manI see, ok17:45:47
@m1cr0man:m1cr0man.comm1cr0manYeah I think we should backport, just to keep the modules similar between this and last release for ease of maintenance (if something bigger comes up)17:46:41
@m1cr0man:m1cr0man.comm1cr0manSo would you simply not change the changelogs at all in this PR, or scrap it to make a backport? I dont think ive ever made a change that edited changelog + was backported :misc17:48:00
@m1cr0man:m1cr0man.comm1cr0man * So would you simply not change the changelogs at all in this PR, or scrap it to make a backport? I dont think ive ever made a change that edited changelog + was backported 😜17:48:06
@hexa:lossy.networkhexaadd the changelog on for release-21.05 on master, then backport18:10:36
@hexa:lossy.networkhexathe only way right now is to backport18:10:51
@m1cr0man:m1cr0man.comm1cr0manok grand that makes sense18:15:10
@hexa:lossy.networkhexa * add the changelog for release-21.05 on master, then backport19:06:26
31 May 2021
@m1cr0man:m1cr0man.comm1cr0manDerp.. didn't even check if he put it in the right changelog 🤦‍♂️22:16:12
@hexa:lossy.networkhexa right, and release is happening today 22:18:53

Show newer messages


Back to Room ListRoom Version: 6