!MthpOIxqJhTgrMNxDS:nixos.org

NixOS ACME / LetsEncrypt

105 Members
Another day, another cert renewal44 Servers

Load older messages


SenderMessageTime
30 May 2021
@hexa:lossy.networkhexaand by that matter: to which changelog to add this14:51:49
@m1cr0man:m1cr0man.comm1cr0manWould you not just add to 21.05 changelog when making the backport commit/PR?15:56:51
@hexa:lossy.networkhexaneeds to go into only one changelog though16:04:57
@hexa:lossy.networkhexaso either backport to 21.05, then add it there16:05:06
@hexa:lossy.networkhexaor keep it for 21.1116:05:13
@hexa:lossy.networkhexashould be part of the changelog were it was first introduced to endusers16:05:23
@m1cr0man:m1cr0man.comm1cr0manI see, ok17:45:47
@m1cr0man:m1cr0man.comm1cr0manYeah I think we should backport, just to keep the modules similar between this and last release for ease of maintenance (if something bigger comes up)17:46:41
@m1cr0man:m1cr0man.comm1cr0manSo would you simply not change the changelogs at all in this PR, or scrap it to make a backport? I dont think ive ever made a change that edited changelog + was backported :misc17:48:00
@m1cr0man:m1cr0man.comm1cr0man * So would you simply not change the changelogs at all in this PR, or scrap it to make a backport? I dont think ive ever made a change that edited changelog + was backported 😜17:48:06
@hexa:lossy.networkhexaadd the changelog on for release-21.05 on master, then backport18:10:36
@hexa:lossy.networkhexathe only way right now is to backport18:10:51
@m1cr0man:m1cr0man.comm1cr0manok grand that makes sense18:15:10
@hexa:lossy.networkhexa * add the changelog for release-21.05 on master, then backport19:06:26
31 May 2021
@m1cr0man:m1cr0man.comm1cr0manDerp.. didn't even check if he put it in the right changelog 🤦‍♂️22:16:12
@hexa:lossy.networkhexa right, and release is happening today 22:18:53
@hexa:lossy.networkhexathis is going great22:19:00
@m1cr0man:m1cr0man.comm1cr0manfeck XD Well I was 14 hours late with my review anyway, he probably already went offline22:27:24
@m1cr0man:m1cr0man.comm1cr0manIt wouldnt be the acme module if we weren't delaying release because of an open PR. Albeit, they are normally open for months before rather than a day22:29:13
@m1cr0man:m1cr0man.comm1cr0manAnd fwiw I dont think this one is a release-blocker. Practically all users will be unaffected by this22:30:33
@hexa:lossy.networkhexa m1cr0man: I'M fixing this up now 22:40:49
@hexa:lossy.networkhexafixed22:42:51
@hexa:lossy.networkhexalet's see if the manual is happy, then merge and backport22:44:04
@hexa:lossy.networkhexadone23:19:33
1 Jun 2021
@0x4a6f:matrix.org[0x4A6F] joined the room.06:49:27
@arianvp:matrix.orgArian grahamc (he/him) can you also me me mod of this channel? Thnx 13:07:46
@grahamc:nixos.org@grahamc:nixos.orgchanged room power levels.14:36:36
@grahamc:nixos.org@grahamc:nixos.org:thum14:36:41
@grahamc:nixos.org@grahamc:nixos.org * 👍️14:36:42
@m1cr0man:m1cr0man.comm1cr0man
In reply to @hexa:lossy.network
m1cr0man: I'M fixing this up now
Good man thanks for doing that :) Also I like how you handled the double space comment.. I never really know what to say that comes off politely when I don't want to go through a full PR + commit for such a trivial change. Normally I just stage the changes locally so that they are captured in my next real commit
18:28:58

Show newer messages


Back to Room ListRoom Version: 6