!MthpOIxqJhTgrMNxDS:nixos.org

NixOS ACME / LetsEncrypt

104 Members
Another day, another cert renewal44 Servers

Load older messages


SenderMessageTime
5 Mar 2022
@winterqt:nixos.devWinter (she/her)
In reply to @m1cr0man:m1cr0man.com
Yeah that's probably best, and so that it's on record on Github too
Would it be appropriate to label the issue as a bug?
19:34:00
@winterqt:nixos.devWinter (she/her)(don't wanna open an issue with no label idk)19:34:07
@winterqt:nixos.devWinter (she/her)i think so19:34:22
@m1cr0man:m1cr0man.comm1cr0manhah uh idk what label to use honestly 😅 I think it's more just discussion atm, nothing is wrong per se19:34:33
@m1cr0man:m1cr0man.comm1cr0man * hah uh idk what label to use honestly 😅 I think it's more just discussion/suggestion atm, nothing is wrong per se19:34:40
@winterqt:nixos.devWinter (she/her)true19:34:43
@winterqt:nixos.devWinter (she/her)yeah ill do no label19:34:53
@winterqt:nixos.devWinter (she/her) m1cr0man: am i just blind, or is the group option for not defined in certOpts? 19:51:09
@winterqt:nixos.devWinter (she/her) * m1cr0man: am i just blind, or is the group option not defined in certOpts? 19:51:14
@m1cr0man:m1cr0man.comm1cr0manit's defined in the inheritableModule thing19:51:23
@winterqt:nixos.devWinter (she/her)oh19:51:53
@winterqt:nixos.devWinter (she/her)
      group = mkOption {
        type = types.str;
        inherit (defaultAndText "group" "acme") default defaultText;
        description = "Group running the ACME client.";
      };

i feel like this description is inaccurate?

19:52:02
@winterqt:nixos.devWinter (she/her)oh nevermind19:52:24
@winterqt:nixos.devWinter (she/her)guess its not19:52:27
@winterqt:nixos.devWinter (she/her)
        # Group might change between runs, re-apply it
        chown '${user}:${data.group}' certificates/*

hm

19:52:57
@m1cr0man:m1cr0man.comm1cr0manyeah that's 100% necessary19:53:11
@m1cr0man:m1cr0man.comm1cr0manran into it myself and covered by the test suite19:53:19
@winterqt:nixos.devWinter (she/her)so is that if the certificate doest have to be renewed, but the group changed?19:53:33
@winterqt:nixos.devWinter (she/her) * so is that for if the certificate doesn't have to be renewed, but the group changed?19:53:41
@m1cr0man:m1cr0man.comm1cr0manthat description might be a bit misleading I agree. It shuold maybe indicate that group will own the certs19:53:41
@m1cr0man:m1cr0man.comm1cr0manyeah exacrly19:53:46
@winterqt:nixos.devWinter (she/her)got it19:53:48
@m1cr0man:m1cr0man.comm1cr0man * yeah exactly19:53:49
@winterqt:nixos.devWinter (she/her)

Secondly there was in the past some concern raised around granting acme group to other services because it would grant that service access to more certs than you may want. You might get some backlash in that regard. In reality, this is hard to operate around and for wildcard certs you're likely to only have 1 cert shared across multiple services anyway.

so the thing about this point is that, like, if you set a specific group for a cert (that isn't acme), then its not like granting the acme group will give you access to those...

19:54:47
@winterqt:nixos.devWinter (she/her) it'll just give the acme owned ones 19:54:55
@winterqt:nixos.devWinter (she/her)like, i get the issue in theory, and i agree with it but not practically?19:55:08
@winterqt:nixos.devWinter (she/her)like i guess it's just about reducing attack surface no matter the setup19:55:18
@m1cr0man:m1cr0man.comm1cr0manwell if you aren't using wildcards its more apparent - certs for each service, with the group assigned appropriately19:55:39
@winterqt:nixos.devWinter (she/her) but giving the acme group won't give access to those? 19:55:58
@winterqt:nixos.devWinter (she/her)that's the point i'm trying to make, unless i'm wrong19:56:07

Show newer messages


Back to Room ListRoom Version: 6