| 30 May 2021 |
hexa | add the changelog on for release-21.05 on master, then backport | 18:10:36 |
hexa | the only way right now is to backport | 18:10:51 |
m1cr0man | ok grand that makes sense | 18:15:10 |
hexa | * add the changelog for release-21.05 on master, then backport | 19:06:26 |
| 31 May 2021 |
m1cr0man | Derp.. didn't even check if he put it in the right changelog 🤦♂️ | 22:16:12 |
hexa | right, and release is happening today | 22:18:53 |
hexa | this is going great | 22:19:00 |
m1cr0man | feck XD Well I was 14 hours late with my review anyway, he probably already went offline | 22:27:24 |
m1cr0man | It wouldnt be the acme module if we weren't delaying release because of an open PR. Albeit, they are normally open for months before rather than a day | 22:29:13 |
m1cr0man | And fwiw I dont think this one is a release-blocker. Practically all users will be unaffected by this | 22:30:33 |
hexa | m1cr0man: I'M fixing this up now | 22:40:49 |
hexa | fixed | 22:42:51 |
hexa | let's see if the manual is happy, then merge and backport | 22:44:04 |
hexa | done | 23:19:33 |
| 1 Jun 2021 |
| [0x4A6F] joined the room. | 06:49:27 |
Arian | grahamc (he/him) can you also me me mod of this channel? Thnx | 13:07:46 |
| @grahamc:nixos.orgchanged room power levels. | 14:36:36 |
@grahamc:nixos.org | :thum | 14:36:41 |
@grahamc:nixos.org | * 👍️ | 14:36:42 |
m1cr0man | In reply to @hexa:lossy.network m1cr0man: I'M fixing this up now Good man thanks for doing that :) Also I like how you handled the double space comment.. I never really know what to say that comes off politely when I don't want to go through a full PR + commit for such a trivial change. Normally I just stage the changes locally so that they are captured in my next real commit | 18:28:58 |
hexa | yeah, I think there is little harm in the double space thingy :) | 18:29:33 |
hexa | just wanted to make sure it's part of the release notes once they come out | 18:30:04 |
m1cr0man | https://github.com/NixOS/nixpkgs/pull/125256 This looks fine to me, I had to dig through acme module and check that there were no other dependencies on webroot and sure enough there isnt. My only thought is that you would have to go into the lego docs to find the default port that's gonna run on. Should we add a Nix option for the legoHttpPort? | 18:39:20 |
| 2 Jun 2021 |
hexa | --http.webroot value Set the webroot folder to use for HTTP based challenges to write directly in a file in .well-known/acme-challenge. This disables the built-in server and expects the given directory to be publicly served with access to .well-known/acme-challenge
| 00:33:03 |
hexa | not defaulting to http.webroot sgtm, same as reuseKey, hard to remove | 00:33:26 |
hexa | --http.port value Set the port and interface to use for HTTP based challenges to listen on.Supported: interface:port or :port. (default: ":80")
| 00:33:59 |
hexa | allowing to set http.port instead sgtm, and in fact CAP_BIND_NET_SERVICE could be conditional on the port being < 1024 | 00:34:30 |
hexa | though doesn't letsencrypt check on 80/tcp? is that even an option? | 00:35:15 |
| 3 Jun 2021 |
hexa | would love some feedback or a merge on https://github.com/NixOS/nixpkgs/pull/123258 | 03:25:49 |
hexa | PSA: update-owner-name in knot 3.0 is "case-sensitive", so a.example.com will not match a.example.com. | 17:25:11 |