| 10 Jul 2025 |
 emily | busy today and I'm sure m1cr0man will be more thorough than myself but I'll see if I can find time to take a quick look over the weekend | 14:16:11 |
| emily | frankly the module has grown so big that I find it hard to keep track of everything to review changes | 14:16:28 |
| emily | though I'd be very happy to review PRs that reduce the number of lines :D | 14:16:51 |
 Christian Theune | Understood. Overall it's a few more lines but I think the module itself is same length or shorter, but overall simpler. There's some places that could be DRY'd but at n=3 I'm still wary of early abstraction. Most new lines are in tests, I think. | 19:53:42 |
| 14 Jul 2025 |
 m1cr0man | I have been reviewing the change bit by bit for the last few days. Haven't had much time to sit down continuously. About 70% done | 07:34:45 |
| Christian Theune | thanks! i know it's a big one ... | 07:35:27 |
| Christian Theune | i'll be on vacation starting from thursday - no pressure, but don't expect a reply between thursday and august 5h. i'll pick this up afterwards if need be. | 07:35:55 |
 hexa | currently otherwise occupied with … mail. | 23:12:17 |
| hexa | * currently otherwise occupied with … mail stuff. | 23:12:20 |
| 15 Jul 2025 |
| m1cr0man | I'm on vacation until a similar time at EOM, so that works out :) I'll try and drop the review before my holiday | 00:00:08 |
| Christian Theune | 🙂 | 06:13:53 |
| 24 Jul 2025 |
|  blocklisted joined the room. | 10:10:53 |
| 28 Jul 2025 |
|  John joined the room. | 08:01:26 |
| 4 Aug 2025 |
| m1cr0man | Christian Theune: Just sent the review there. Sorry it took so long, I was on call the week before my holiday and was way too mentally exhausted to look at more code. | 14:43:09 |
| 5 Aug 2025 |
| Christian Theune | no worries. today's my first day back from vacation, so ... that fits perfectly 😉 | 06:15:24 |
| Christian Theune | (although that's not gonna be the first thing i'll touch today 😉 ) | 06:15:41 |
| 7 Aug 2025 |
|  Stéphan left the room. | 07:54:30 |
| 8 Aug 2025 |
|  0x4A6F joined the room. | 06:58:40 |
| Christian Theune | m1cr0man: great review, thanks! i'm wrapping things up on my side now (and found a few more minor details to polish). will poke here again in a bit once tests are clean on my side. | 13:24:58 |
| Christian Theune | alright. my PR is updated, there is some documentation issue that confused me (haven't touched docs before) that leona can likely help me fix next week. otherwise i've responded to all your comments and adapted the code here and there. | 14:19:49 |
| 9 Aug 2025 |
| m1cr0man | Just re-reviewed and approved it :) Thanks once again. It seems ofborg had an internal error when processing your last commit to the PR. you might have to trigger a force-push again.. or at least that's what I think will fix it. I've never seen that before. | 12:58:01 |
| Christian Theune | 🙂 | 12:59:12 |
| Christian Theune | hmm. good question. i'll ask leona | 12:59:25 |
 leona | force push will most likely work, otherwise also not that important | 13:01:28 |
| 11 Aug 2025 |
|  Spaenny changed their display name from Philipp to Spaenny. | 14:46:48 |
| 12 Aug 2025 |
| Christian Theune | i think it worked | 13:34:43 |
| Christian Theune | m1cr0man: want to do the honors and press the merge button? | 13:34:50 |
| m1cr0man | Sadly I'm not on the committers list yet so I can't merge it 😅 | 13:47:41 |
| leona | I can probably also take another look soon | 13:48:02 |
| leona | If noone else wants ^^ | 13:48:09 |
