| 3 Jun 2024 |
 Sandro 🐧 | In reply to @arianvp:matrix.org
We also have https://github.com/NixOS/nixpkgs/pull/244511 which limits concurrent domain creation. I didn't realise that landed I think that is mainly there to prevent going immediately into the rate limit of something fails | 10:12:21 |
| Sandro 🐧 | I mean we should probably do a release notes entry either way | 10:12:40 |
| Sandro 🐧 | And testing state changes like that should probably not be done to quick to not create the next bugs 😅 | 10:12:56 |
| Sandro 🐧 | Also merge that test please 😅🙈 | 10:13:04 |
| Sandro 🐧 | Can't you mitigate this by setting the URL back to null? | 10:15:21 |
| Sandro 🐧 | I think no one mentioned that yet | 10:15:27 |
 Arian | no because we removed the nullOr from the type | 10:16:02 |
| Arian | but we could add that!! | 10:16:04 |
| Arian | good idea. | 10:16:09 |
| Arian | Good thinking | 10:16:28 |
 Stéphan | I like that too. Something like this? https://github.com/NixOS/nixpkgs/compare/master...stephank:nixpkgs:fix-acme2 | 11:00:06 |
| Sandro 🐧 | Maybe we should couple that with a warning that people should set the URL explicit | 11:23:12 |
| Sandro 🐧 | but then, is that worth it? I dono | 11:23:20 |
 CPU | In reply to @arianvp:matrix.org
If there are any volunteers to join the team just yell ;) :wave: I would be interested. Is commented on #316854 the best way to get looped in? | 14:45:48 |
| CPU | In reply to @arianvp:matrix.org
If there are any volunteers to join the team just yell ;) * :wave: I would be interested. Is commenting on #316854 the best way to get looped in? | 14:45:54 |
| Arian | Stéphan: yeh that looks perfect. Wanna open a PR for that? | 18:42:18 |
| 4 Jun 2024 |
|  raitobezarius changed their display name from raitobezarius (DECT: 7248) to raitobezarius. | 11:14:33 |
 osnyx (he/him) | In reply to @stephank:stephank.nl
I like that too. Something like this? https://github.com/NixOS/nixpkgs/compare/master...stephank:nixpkgs:fix-acme2 Looks good, IMHO that's a good alternative to the state convergence approach. | 13:56:18 |
| osnyx (he/him) | In reply to @stephank:stephank.nl
I like that too. Something like this? https://github.com/NixOS/nixpkgs/compare/master...stephank:nixpkgs:fix-acme2 * Looks good, IMHO that's a decent alternative to the state convergence approach. | 13:56:34 |
 m1cr0man | https://github.com/NixOS/nixpkgs/pull/270221 damn, had I seen this I would have reviewed for sure | 18:32:08 |
| m1cr0man | Literally started a new job today, sorry I haven't been around for the incident | 18:32:26 |
| Arian | Congrats on the new job! | 18:54:49 |
| Arian | https://github.com/NixOS/nixpkgs/pull/317257 | 18:55:17 |
| Arian | Also added https://github.com/NixOS/nixpkgs/pull/317261 so we get automatically tagged for review in the future | 18:56:41 |
| m1cr0man | Thank you 🙂. Okay, I can review those. Possibly right now | 18:57:33 |
| Arian | The backport failed to due a merge conflict and my git foo is not good enough. Help would be appreciated https://github.com/NixOS/nixpkgs/pull/317257#issuecomment-2148339873 | 20:13:59 |
| Arian | it's late here and my brain is fried :') | 20:14:14 |
| Sandro 🐧 | git checkout release-24.11 -b backport-xxxx
git cherry-pick hash
vim file/path
fix the issue
git add file/path
git cherry-pick --continue
git push
| 20:36:47 |
| Sandro 🐧 | * git checkout release-24.11 -b backport-xxxx
git cherry-pick hash
vim file/path
# fix the issue
git add file/path
git cherry-pick --continue
git push
| 20:36:58 |
| Sandro 🐧 | and yeah, that PR should be backported 🙂 | 20:37:37 |
