| 16 May 2025 |
 hexa | and keyType always has a default | 09:25:21 |
| hexa | so yeah, no | 09:25:26 |
| hexa | also can the acme team please just dissolve? | 09:26:41 |
| hexa | it is clearly m1cr0man who reviews everything | 09:27:43 |
| hexa | and then someone active in this room merging the thing | 09:27:53 |
| hexa | aanderse, Arian please reconsider your ACME team membership | 09:28:17 |
| hexa | also https://github.com/orgs/NixOS/teams/acme has no maintainer role set | 09:33:38 |
| hexa | m1cr0man: ask in #org_owners:nixos.org to for that role | 09:33:59 |
| hexa | m1cr0man: ok, I think we're good. I pushed the test to that PR, so the only thing missing is release notes entry. | 10:45:27 |
| hexa | I'm grabbing lunch and will run the tests in the meantime | 10:45:54 |
 m1cr0man | In reply to @hexa:lossy.network
m1cr0man: ask in #org_owners:nixos.org to for that role Will do, thanks | 10:46:44 |
 Arian | I have no opinions about the existence or non-existence of the team. It was created in a time where most of this was complete wild-west and it was an easy way for people to ask for review when they touched the module | 10:47:33 |
| hexa | Yeah, and no we're years in with the team rarely chiming in on any of the changes that m1cr0man reviews | 10:48:04 |
| hexa | Feels like the third release where we push some final change over the finish line just before branch-off. | 10:48:20 |
| hexa | * Yeah, and now we're years in with the team rarely chiming in on any of the changes that m1cr0man reviews | 10:48:33 |
| m1cr0man | Oh I'm not pushed about it being in before branch off, but for this user it would be nice since it has been open for a long time. I'll try write a change log entry on my lunch | 10:48:56 |
| hexa | The change does not look breaking to me, so it can in fact be merged before (or even after) branch-off. | 10:49:49 |
| Arian | If the problem is to get something merged after approval; why not use the merge bot? | 10:50:44 |
| hexa | The merge-bot only works for PRs created by r-ryantm | 11:05:48 |
| hexa | * The merge-bot only works for PRs and changes created by r-ryantm | 11:05:57 |
| hexa | The issue is IMO that the change has been sitting too long already. | 11:11:33 |
| hexa | And for no good reason. | 11:11:44 |
 emily | it actually works for all PRs now | 11:49:42 |
| emily | but I think only for by-name packages, not modules | 11:49:48 |
| hexa | That is news to me | 11:50:45 |
| emily | I think it is long past due for m1cr0man to get commit bit tbh (and I am sorry for not putting more time into ACME the past few years, though I do still look at/sometimes comment on PRs) | 11:50:48 |
| emily | it was not announced super loudly :) | 11:50:56 |
| emily | oh, maybe it's only PRs made by committers: https://discourse.nixos.org/t/nixpkgs-merge-bot-committer-pull-request-merge-strategy/58227 | 11:51:19 |
| emily | put a nomination up https://github.com/NixOS/nixpkgs/issues/321665#issuecomment-2886516818 | 11:58:10 |
| m1cr0man | Oh, well thank you 🙂 I never really wanted to ask as the level of responsibility and commitment it implies is more than I thought I deserve for the consistency in my contributions | 13:05:08 |
