| 16 May 2025 |
hexa | The change does not look breaking to me, so it can in fact be merged before (or even after) branch-off. | 10:49:49 |
Arian | If the problem is to get something merged after approval; why not use the merge bot? | 10:50:44 |
hexa | The merge-bot only works for PRs created by r-ryantm | 11:05:48 |
hexa | * The merge-bot only works for PRs and changes created by r-ryantm | 11:05:57 |
hexa | The issue is IMO that the change has been sitting too long already. | 11:11:33 |
hexa | And for no good reason. | 11:11:44 |
emily | it actually works for all PRs now | 11:49:42 |
emily | but I think only for by-name packages, not modules | 11:49:48 |
hexa | That is news to me | 11:50:45 |
emily | I think it is long past due for m1cr0man to get commit bit tbh (and I am sorry for not putting more time into ACME the past few years, though I do still look at/sometimes comment on PRs) | 11:50:48 |
emily | it was not announced super loudly :) | 11:50:56 |
emily | oh, maybe it's only PRs made by committers: https://discourse.nixos.org/t/nixpkgs-merge-bot-committer-pull-request-merge-strategy/58227 | 11:51:19 |
emily | put a nomination up https://github.com/NixOS/nixpkgs/issues/321665#issuecomment-2886516818 | 11:58:10 |
m1cr0man | Oh, well thank you 🙂 I never really wanted to ask as the level of responsibility and commitment it implies is more than I thought I deserve for the consistency in my contributions | 13:05:08 |
m1cr0man | In reply to @emilazy:matrix.org I think it is long past due for m1cr0man to get commit bit tbh (and I am sorry for not putting more time into ACME the past few years, though I do still look at/sometimes comment on PRs) Aren't you on the steering committee plus half a dozen other projects? 😂 Yeah don't worry about it. I appreciate the time you put in here helping steer the design back when you started contributing | 13:06:29 |
emily | I think it's more responsibility than commitment :) | 13:06:36 |
emily | as long as you/the project get value out of you being able to hit the merge button, and you hit it responsibly, it's all good for any level of activity > 0 | 13:07:00 |
emily | (not on the SC, thank god) | 13:07:46 |
emily | (but I do try to juggle too many hats) | 13:07:53 |
m1cr0man | Ah sorry, mixing people up 😅 but I still see you everywhere | 13:08:05 |
emily | I can't believe the rewrite was half a decade ago now… | 13:08:16 |
m1cr0man | .pfffff. I did it for my uni's network society and I'm pretty sure it's still doing the heavy lifting to this day. Isn't it over half a decade like 2019? Jeez | 13:09:35 |
emily | it was 2020 | 13:15:19 |
emily | feels like yesterday, though | 13:15:35 |
m1cr0man | https://github.com/m1cr0man/nixpkgs/commit/8fb8d665ddc993f859a96e73a1c51982eac72b94 wrote a wee changelog hexa , not sure if you want to commit this up to codemaster's branch or if I create a separate PR | 13:34:28 |
hexa | picking | 14:02:43 |
| 21 May 2025 |
| Spaenny joined the room. | 10:57:09 |
| 23 May 2025 |
woobilicious | Is there an easy way to disable acme for test servers/vms? I know nixos-rebuild has a profile system, would that be how you do it? | 00:15:39 |
hexa | not an acme specific question | 00:36:18 |
hexa | you would need to nuke security.acme.certs to an empty attreset | 00:37:25 |