3 Jun 2024 |
Sandro π§ | but then, is that worth it? I dono | 11:23:20 |
CPU | In reply to @arianvp:matrix.org If there are any volunteers to join the team just yell ;) :wave: I would be interested. Is commented on #316854 the best way to get looped in? | 14:45:48 |
CPU | In reply to @arianvp:matrix.org If there are any volunteers to join the team just yell ;) * :wave: I would be interested. Is commenting on #316854 the best way to get looped in? | 14:45:54 |
Arian | StΓ©phan: yeh that looks perfect. Wanna open a PR for that? | 18:42:18 |
4 Jun 2024 |
| raitobezarius changed their display name from raitobezarius (DECT: 7248) to raitobezarius. | 11:14:33 |
osnyx (he/him) | In reply to @stephank:stephank.nl I like that too. Something like this? https://github.com/NixOS/nixpkgs/compare/master...stephank:nixpkgs:fix-acme2 Looks good, IMHO that's a good alternative to the state convergence approach. | 13:56:18 |
osnyx (he/him) | In reply to @stephank:stephank.nl I like that too. Something like this? https://github.com/NixOS/nixpkgs/compare/master...stephank:nixpkgs:fix-acme2 * Looks good, IMHO that's a decent alternative to the state convergence approach. | 13:56:34 |
m1cr0man | https://github.com/NixOS/nixpkgs/pull/270221 damn, had I seen this I would have reviewed for sure | 18:32:08 |
m1cr0man | Literally started a new job today, sorry I haven't been around for the incident | 18:32:26 |
Arian | Congrats on the new job! | 18:54:49 |
Arian | https://github.com/NixOS/nixpkgs/pull/317257 | 18:55:17 |
Arian | Also added https://github.com/NixOS/nixpkgs/pull/317261 so we get automatically tagged for review in the future | 18:56:41 |
m1cr0man | Thank you π. Okay, I can review those. Possibly right now | 18:57:33 |
Arian | The backport failed to due a merge conflict and my git foo is not good enough. Help would be appreciated https://github.com/NixOS/nixpkgs/pull/317257#issuecomment-2148339873 | 20:13:59 |
Arian | it's late here and my brain is fried :') | 20:14:14 |
Sandro π§ | git checkout release-24.11 -b backport-xxxx git cherry-pick hash vim file/path
fix the issue
git add file/path git cherry-pick --continue git push
| 20:36:47 |
Sandro π§ | * git checkout release-24.11 -b backport-xxxx
git cherry-pick hash
vim file/path
# fix the issue
git add file/path
git cherry-pick --continue
git push
| 20:36:58 |
Sandro π§ | and yeah, that PR should be backported π | 20:37:37 |
m1cr0man | In reply to @sandro:supersandro.de
git checkout release-24.11 -b backport-xxxx
git cherry-pick hash
vim file/path
# fix the issue
git add file/path
git cherry-pick --continue
git push
Huh, did not know you could check out a ref with -b at the same time. I always checkout then checkout again π | 20:54:34 |
Sandro π§ | In reply to @m1cr0man:m1cr0man.com Huh, did not know you could check out a ref with -b at the same time. I always checkout then checkout again π TYL | 22:01:39 |
5 Jun 2024 |
Arian | all done! thanks all | 06:37:01 |
StΓ©phan | Arian: Thanks for carrying the PR through. I'm in the middle of a move, so couldn't respond in time. π | 08:07:45 |
7 Jun 2024 |
| @alex3829:matrix.org removed their display name real_z2. | 23:44:21 |
24 Jun 2024 |
| @janik0:matrix.org left the room. | 13:05:57 |
29 Jun 2024 |
| mib π₯ joined the room. | 22:24:48 |
2 Jul 2024 |
osnyx (he/him) | Hey, any progress on https://github.com/NixOS/nixpkgs/pull/318818? The tests now pass. | 20:59:58 |
emily | is the aarch64 failure just flakiness? | 21:03:10 |
osnyx (he/him) | Good question, I don't have the hardware. I can see whether I can re-trigger the ofborg test. But I can say that the test failure is not in the subtest I've touched, but much earlier. | 21:36:01 |
osnyx (he/him) | I'm using ofborg far too rarely, is it possible to call the test just for a specific platform? | 21:38:24 |
emily | I think just asking it to run all the tests is fine, although I forget if it'll do it with no changes or not | 21:39:11 |