| 4 Sep 2023 |
 raitobezarius | I'd rather focus on bringing the feature to systemd | 13:55:08 |
| raitobezarius | And let you folks figure out what you prefer to do here in Nixpkgs as long as you find an agreement :) | 13:55:19 |
 m1cr0man | Yeah I agree but no one in this room (afaik) has the skills or time to do so | 13:55:37 |
 osnyx (he/him) | In reply to @raitobezarius:matrix.org
I'd rather focus on bringing the feature to systemd As I said earlier, once this is ready I'll happily help with porting things over. | 13:55:38 |
| raitobezarius | In reply to @m1cr0man:m1cr0man.com
Yeah I agree but no one in this room (afaik) has the skills or time to do so I do have the time and skills to bring it to systemd ;) | 13:56:10 |
| raitobezarius | I mean, time, well, I can always find some in another dimension :) | 13:56:18 |
| raitobezarius | * I mean, time, well, I can always find some in another dimension :) | 13:56:21 |
| osnyx (he/him) | For my PR, I'll happily ad the missing tests, I just didn't want to put any more time into something struggling to get any traction. | 13:56:35 |
| raitobezarius | But I don't think it's reasonable to block indefinitely something on the hope of seeing it merged | 13:56:38 |
| m1cr0man | In reply to @raitobezarius:matrix.org
I do have the time and skills to bring it to systemd ;) Oh neat okay, I didn't realize 😅 | 13:56:48 |
| raitobezarius | But I cannot grasp the maintenance overhead merging this would create | 13:56:52 |
| m1cr0man | It's added complexity to the Acme units. I've been pretty adverse to feature additions because it creates new failure scenarios and it's already got crazy feature creep but in this instance it's pretty important to have a rate limit and I've seen the effects of it first hand. | 13:58:14 |
| osnyx (he/him) | In reply to @m1cr0man:m1cr0man.com
I think your arguments are solid. I'm not on board for waiting for systemd to add features (and your hammer saying is the same reason why). Like I said if you're willing to just be around to take questions or PR fixes into that portion of the module, I'm happy to see your one merged. I do think it is more complicated but I can live with that if I'm not the only one that understands how it works.
I would like you to copy over the test case I made though, to prevent future regressions That's why I wanted to get another opinion of the team regarding not the only one that understands how it works.
I try to get the tests in this week. | 13:59:31 |
| raitobezarius | I think it's fair that we set the "direction of the ACME module" to: we can welcome this feature and urge/usher into an era where systemd will provide it and we can decrease the complexity in the future | 14:05:46 |
| m1cr0man | I also want to upstream some stuff to Lego, so between the two hopefully complexity will fall over the next while. | 14:11:31 |
| osnyx (he/him) | * My take on the "let's solve it with systemd unit options alone" approach is just the idea that we must be careful to not fall into the when all you want to use is a systemd-253 hammer, everything looks like a unit option nail.
It might be a hammer you know, but that hammer bight also just be adding things to the evergrowing list of interwoven systemd unit relationships… | 14:24:55 |
| osnyx (he/him) changed their display name from Oliver Schmidt to osnyx (he/him). | 20:10:48 |
| 9 Sep 2023 |
| osnyx (he/him) | m1cr0man: Can you take care of the concurrency PR or shall I use the opportunity at NixCon to ask some other ACME team maintainers as well? | 17:13:59 |
| m1cr0man | Yo merge it? You need to ask like anyone with merge permissions. I approved it right? | 17:15:21 |
| osnyx (he/him) | In reply to @m1cr0man:m1cr0man.com
Yo merge it? You need to ask like anyone with merge permissions. I approved it right? I cannot see any approval, sorry. | 17:40:41 |
| osnyx (he/him) | There's a merge party right now. So I guess I should still squash the commits I guess? | 17:41:07 |
| osnyx (he/him) | https://github.com/NixOS/nixpkgs/pull/244511 | 17:41:33 |
| osnyx (he/him) | So in case I get your approval, I can certainly get it merged. | 17:42:26 |
| m1cr0man | Ah well I can do that | 17:43:06 |
| osnyx (he/him) | I'll squash the commits, give me a sec | 17:43:21 |
| osnyx (he/him) | m1cr0man: squashed an pushed | 17:45:28 |
| m1cr0man | Cool ok | 17:45:42 |
| osnyx (he/him) | Thanks a lot | 17:54:08 |
