| 8 Jul 2022 |
Wanja Hentze | I might give that a try, but I'll pick some more low-hanging fruit first | 15:59:53 |
Wanja Hentze | Next one: https://github.com/NixOS/nixpkgs/pull/180739 | 16:08:52 |
Wanja Hentze | This one has been in unstable for a while now, but the backport fell through the cracks | 16:09:17 |
Alyssa Ross | whentze: PRs or not-yet-discussed CVEs can go in the triage channel I think | 16:10:33 |
Alyssa Ross | the point is to not lose those things in the noise of discussion | 16:10:40 |
Wanja Hentze | oh ok | 16:10:56 |
@andreas.schraegle:helsinki-systems.de | In reply to @whentze:matrix.org Next one: https://github.com/NixOS/nixpkgs/pull/180739 feel free to cross-post to #php:nixos.org, if you want maintainer feedback. although for these patch releases, they probably don't need to be involved. | 16:11:43 |
Wanja Hentze | I figured so, especially because it's already merged into master and a PHP maintainer commented there that it should be backported | 16:12:23 |
Wanja Hentze | (https://github.com/NixOS/nixpkgs/pull/177136#issuecomment-1152151418) | 16:12:34 |
@andreas.schraegle:helsinki-systems.de | yeah, the issue was that the automatic backport doesn't work for them anymore, I think. that and everyone just forgot about it, apparently.
anyways, thanks for taking care of this. | 16:13:33 |
| kn set a profile picture. | 17:05:20 |
Winter (she/her) | why does #180744 cause so many Linux rebuilds for just a vim version bump 🤔
do that many things rely on vim...? i don't think it's in stdenv so not sure what else could depend on it | 17:15:31 |
Wanja Hentze | I was wondering the same | 17:18:42 |
Winter (she/her) | huh, #179537 (another vim bump) caused more darwin rebuilds than this one | 17:21:01 |
Winter (she/her) | unless ofborg is still going through darwin or something | 17:21:17 |
Wanja Hentze | the darwin queue is very slow today I think | 17:21:57 |
Winter (she/her) | don't think the labels rely on build machines, just relies on eval | 17:26:54 |
Winter (she/her) | Wanja Hentze: did you omit the sha256- prefix on purpose in the Vim hash? don't think i've seen that done before (not surprised it works though) | 17:29:19 |
Wanja Hentze | semi-on-purpose? | 17:29:52 |
Wanja Hentze | I left it off because the old version didn't have it | 17:29:59 |
Wanja Hentze | I have no idea when it's actually required | 17:30:09 |
Wanja Hentze | there are like 5 formats for the hash and I've totally lost track | 17:30:30 |
Winter (she/her) | In reply to @whentze:matrix.org I left it off because the old version didn't have it the old version was using a base32 hash, you used a base64 hash; usually for base64 hashes we include the sha256 prefix | 17:31:42 |
Wanja Hentze | oh, I see | 17:32:03 |
Winter (she/her) | again i'm totally nitpicking here sorry 😅 | 17:32:25 |
Wanja Hentze | well, maybe that's causing the mass rebuild for some silly reason?! | 17:32:38 |
Wanja Hentze | maybe it has to pull in a general AI now to figure out which hash format I meant | 17:32:56 |
Winter (she/her) | but yeah just for consistency's sake i would recommend fixing that, if you don't mind | 17:34:42 |
Wanja Hentze | fixed it | 17:34:41 |
Winter (she/her) | thanks! | 17:35:27 |