Nix NodeJS | 208 Members | |
| 61 Servers |
| Sender | Message | Time |
|---|---|---|
| 4 Jul 2023 | ||
| but it doesn't have a URL | 08:43:09 | |
| Oh really 💀 | 08:43:20 | |
| I hadn't looked at the yarn-berry stuff yet. It's just been on my todo list | 08:43:37 | |
In reply to @janne.hess:helsinki-systems.de
| 08:44:39 | |
| I more or less expect to get to it after the current in-progress PRs are dealt with on the node project board on github, and after npmCheckHook and buildYarnPackage are merged too | 08:45:30 | |
In reply to @janne.hess:helsinki-systems.deYeah, was worried they'd have done that. The references are unfortunate because they're entirely dependent on the locally configured registry (reminds me of another registry we have.... ❄) | 08:46:36 | |
In reply to @janne.hess:helsinki-systems.deThey still have integrity hashes at least, right? | 08:47:30 | |
| Say - instead of parsing the lock, couldn't I just:
or something like this? | 08:47:42 | |
In reply to @lily:lily.flowersThere is a checksum field which looks like a sha512 hash | 08:48:22 | |
In reply to @janne.hess:helsinki-systems.dePossibly. The thing is I know they removed --offline with v2 so we gotta make sure we can still prevent it from needing anything online | 08:48:55 | |
In reply to @janne.hess:helsinki-systems.deIs it sri or just bare sha512? | 08:49:12 | |
In reply to @lily:lily.flowers
| 08:49:21 | |
In reply to @lily:lily.flowersI will try. 5 lines of bash is probably a lot easier than having custom node code that parses 2 different lock files ;) | 08:49:41 | |
In reply to @janne.hess:helsinki-systems.deOh you mean for fetching. I'm not sure if lockfile fixup is still required for git deps for yarn berry or not. It was for yarn1 and so needed a custom fetcher | 08:50:41 | |
In reply to @lily:lily.flowersNo I mean for generating the hash for fetchYarnDeps | 08:51:14 | |
| If lockfile fixup is not needed and their cache format is reproducible, sure that could maybe work | 08:51:29 | |
In reply to @janne.hess:helsinki-systems.deAh both actually… | 08:51:53 | |
In reply to @janne.hess:helsinki-systems.deNo fetchYarnDeps is not the same cache format technically | 08:51:56 | |
| If you're trying to get something specific working, there is a yarn v2+ to yarn v1 lockfile rewriter in nixpkgs that some packages have used | 08:53:05 | |
In reply to @lily:lily.flowersThat's possible? 👀 | 08:53:19 | |
| I thought it was. I may be misremembering? (If it is though, it might be easier if yarn berry turns out to be a lot of trouble to create new tooling for atm) | 08:54:09 | |
| So good news: a yarn offline cache appears to be reproducible | 10:56:58 | |
| 10:57:05 | |
| (we will see if this also builds in a couple of months…) | 10:57:39 | |
In reply to @janne.hess:helsinki-systems.deWait this would still be yarn v1 right? We don't have yarn-berry in nixpkgs yet I thought | 11:02:39 | |
| (Oops meant to set that as a reply to the other message) | 11:02:55 | |
| * (Oops, meant to set that as a reply to the other message) | 11:03:03 | |
In reply to @lily:lily.flowersinteresting… still manages to parse the v2 lockfile | 11:49:39 | |
In reply to @lily:lily.flowers
| 13:37:00 | |
| 5 Jul 2023 | ||
| mkYarnPackage reads the package.json from src. This should work as expected right? in https://github.com/NixOS/nixpkgs/pull/241314 the submitter is saying they're receiving this error when trying to build without copying package.json into nixpkgs: https://gist.github.com/GrahamcOfBorg/77965b591af2aef7b6a5c40bb0d08391 | 13:45:33 | |