| 28 Apr 2023 |
 Lily Foster | Okay I've cleaned up https://github.com/NixOS/nixpkgs/pull/214454, if it could get some reviews or testers (Winter (she/her), I did pull in your other commit to do the cache mapping for hash fixup and cleaned it up, added v1 tests, etc) | 23:31:25 |
| Lily Foster | I think I locally have https://github.com/NixOS/nixpkgs/pull/206477 fixed up but because maintenance was getting increasingly annoying (and I noticed cross concerns), I've integrated the npm patch into the main nodejs derivation and will be testing then pushing if I don't find regressions (debating whether it should be retargeted to staging since I mean the rebuild count for nodejs isn't that high and nodejs updates have gone straight to master in the past) | 23:34:41 |
| Lily Foster | Well I just pushed my testing branch anyway, in case anyone wanted to look at it. I guess we'll see what ofborg says the exact rebuild counts will be | 23:42:24 |
| 30 Apr 2023 |
 aktaboot | If I havea package.json, I don't need a yarn.lock/nix right ? | 08:16:40 |
| aktaboot | just running yarn will create one 👍 | 08:22:57 |
| aktaboot | * just running yarn will create one 👍 | 08:23:02 |
| 3 May 2023 |
|  Federico Schonborn joined the room. | 23:57:24 |
| 4 May 2023 |
| aktaboot left the room. | 19:41:25 |
 hexa | Lily Foster: with the latest buildNpmPackage changes merged I think I get an endless loop in installPhase 😄 | 23:53:18 |
| Lily Foster | In reply to @hexa:lossy.network
Lily Foster: with the latest buildNpmPackage changes merged I think I get an endless loop in installPhase 😄 Pls tell me no.... I will cry.. | 23:54:16 |
| Lily Foster | Derivation? | 23:54:21 |
| hexa | well, before it failed while fetching | 23:54:50 |
| hexa | so maybe this is due to the package itself | 23:54:58 |
| Lily Foster | (I tested these PRs way too much for this 😭) | 23:55:01 |
| hexa | https://github.com/NixOS/nixpkgs/pull/229953 | 23:55:01 |
| Lily Foster | In reply to @hexa:lossy.network
well, before it failed while fetching Was it a timeout? We need to put shorter timeout and retry logic into the fetcher because I've found at least one package often gets lost when it tries to parallel grab everything | 23:55:38 |
| hexa | see the PR description | 23:55:50 |
| hexa |
navidrome-ui> npm ERR! request to https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz failed: cache mode is 'only-if-cached' but no cached response is available.
| 23:56:11 |
| hexa | basically this | 23:56:13 |
| Lily Foster | Oh that's during dep build, not during fetching. And yeah that is what the just-merged PR should fix | 23:56:33 |
| hexa | it did. | 23:56:52 |
| hexa | have been waiting for this change since the end of january 😄 | 23:57:03 |
| hexa | okay, nvm | 23:57:12 |
| hexa | deleted my postInstall thing and tada.wav | 23:57:24 |
| hexa | so let me retry with overwriting the complete installPhase | 23:58:06 |
| Lily Foster | I just checked the package-lock.json and no git deps so you shouldn't need https://github.com/NixOS/nixpkgs/pull/206477 at least. I plan to get that one in too in the next week. I pushed what is hopefully the final diff a bit ago, but I need to do testing to make sure it is actually working as intended | 23:58:53 |
| 5 May 2023 |
| hexa | I also had one that had a git dependency | 00:06:53 |
| hexa | but it is so long ago, I don't even remember which one it was | 00:07:02 |
| hexa | navidrome ui looks good. | 00:07:28 |
| Lily Foster | In reply to @hexa:lossy.network
but it is so long ago, I don't even remember which one it was Hopefully those will work okay enough soon.... Npm just keeps finding new and surprising ways to make those utterly busted though | 00:08:41 |
