| 2 Jun 2023 |
 Lily Foster | In reply to @drupol:matrix.org
No, I must use NodeJS 16. There's no support of NodeJS 18 in coder/code-server yet. I think that's what adamcstephens was saying | 13:35:17 |
| Lily Foster | In reply to @drupol:matrix.org
I would like to review this PR (https://github.com/NixOS/nixpkgs/pull/235445) but I don't really know if the proposal is a good idea or not yet. Request review from me and I'll get to it in the next day or two, thank you! | 13:35:36 |
| Lily Foster | In reply to @adam:valkor.net
Would we consider reverting that change for master/unstable until 16 actually becomes EOL in September? Release managers are not comfortable with that because 16 goes EOL 3.5 months before NixOS 23.05 does. We could maybe revert on master for now but idk if it's worth it for one package | 13:36:34 |
| Lily Foster | Oh I misread, that's what you were suggesting. Yeah maybe we could do that. I would want to know if more than one package is affected though | 13:37:35 |
| Lily Foster | (And still am a tad skeptical) | 13:37:48 |
 raitobezarius | We opened an issue on affected packages for Node.js 16 | 13:37:54 |
| raitobezarius | IMHO, it's not worth it, we should only press on and ping the maintainers so the ping their respective upstreams on going to Node.js 18 at least | 13:38:08 |
| raitobezarius | No matter what, we will find ourselves in September pretty quickly and given my experience with saying hi to upstream, they need time to accomodate | 13:38:27 |
| raitobezarius | Adding a simple permittedInsecurePackages in the meantime is not too shocking and we allowed caching exceptions for Node.js 16 and OpenSSL 1.1 to make the ride less bumpy for everyone | 13:38:47 |
| Lily Foster | Yeah it's an upstream issue anyway. If your package needs 16, you can just enable insecure packages in nixpkgs 🤷♀️ | 13:39:02 |
 adamcstephens | Yeah I figured we wouldn’t want to revert, just putting the question out there. | 13:39:46 |
| Lily Foster | In reply to @raitobezarius:matrix.org
We opened an issue on affected packages for Node.js 16 Oh really? Yeah how many are left? (Also were node maintainers pinged on that issue I don't remember seeing one other than the lists on the PR 🤔) | 13:40:04 |
| raitobezarius | airfield, base16-builder, netlify-cli, spacegun, n8n? | 13:40:35 |
| raitobezarius | are the remaining ones | 13:40:39 |
| raitobezarius | wait I'm not uptodate on master | 13:40:54 |
| Lily Foster | Okay that's not too bad. I thought netlify was already handled though | 13:40:58 |
| Lily Foster | And spacegun has been broken well before the 16 deprecation iirc | 13:41:13 |
| raitobezarius | apologies | 13:41:30 |
| Lily Foster | In reply to @lily:lily.flowers
Okay that's not too bad. I thought netlify was already handled though (Pretty sure I merged Robert's PR for that) | 13:41:36 |
| raitobezarius | we only have netlify-cli left on master | 13:41:36 |
| raitobezarius | then someone forgot to update the generate.sh | 13:41:50 |
| Lily Foster | Oh maybe I'm misremembering then | 13:41:50 |
| raitobezarius | for netlify-cli | 13:41:52 |
| Lily Foster | Oh | 13:41:57 |
| Lily Foster | rip | 13:41:59 |
| raitobezarius | it will still generate with nodejs-16 for the next upgrade | 13:41:59 |
| raitobezarius | but it's true that we don't have netlify cli with nodejs 16 anymore | 13:42:10 |
| raitobezarius | so in fact | 13:42:11 |
| raitobezarius | only codeserver shit is nodejs16 ? | 13:42:16 |
| raitobezarius | this is definitely not worth a rollback | 13:42:21 |
