Nix NodeJS | 201 Members | |
| 56 Servers |
| Sender | Message | Time |
|---|---|---|
| 19 May 2023 | ||
Lily Foster: were you able to work on a solution for retrying package downloads with buildNpmPackage and prefetch-npm-deps already? | 16:12:32 | |
In reply to @denbrahe:matrix.org Yes I've worked on it. I actually found that switching out the ureq library that prefetch-npm-deps is using with something else (e.g. minreq) caused the issues to stop occuring for me We were wanting to have it use isahc instead, but that library was giving us issues with certs for some reason that I haven't had the time to dive into yet I'll let you know when we have more, because the random request failures on poor internet connections thing is annoying | 16:58:33 | |
| Oh, that sounds great! Let me know if I can help with testing or something else! | 17:01:06 | |
| 21 May 2023 | ||
| how are we progressing on the npm PRs? branch-off is now really close | 14:20:18 | |
| https://github.com/NixOS/nixpkgs/pull/206477 is still ready for review and I planned to get back to the npmRoot PR today | 14:23:22 | |
| (Probably in ~3-4 hours) | 14:23:43 | |
| Lily Foster: the PR is good to go IMHO | 14:36:54 | |
| Confirmed with Winter and merged it 🎉 | 15:17:28 | |
| I tested the heck out of it but will still watch the next hydra eval for regressions just in case | 15:17:57 | |
| yeah you have some stabilization days ahead of you if needed :) | 15:25:46 | |
| I have been dreaming those last days about starting the yarn backend for buildNpmPackage | 15:25:55 | |
| hopefully when the branch off is done and things becomes calmer on QEMU, I will do that :) | 15:26:10 | |
| * hopefully when the ~branch off~ release is done and things becomes calmer on QEMU, I will do that :) | 15:26:19 | |
In reply to @raitobezarius:matrix.orgDon't we all | 15:26:38 | |
| yes :D | 15:27:00 | |
In reply to @raitobezarius:matrix.orgI've a few open yarn PRs to help that and there's a draft buildYarnPackage too we'll pick up soon | 15:27:05 | |
| and https://github.com/NixOS/nixpkgs/pull/230991? 😲 | 19:50:04 | |
| should we merge botamusique and navidrome with the npmCOnfigHook reschedule hack? | 19:50:34 | |
| * should we merge botamusique and navidrome with the npmConfigHook reschedule hack? | 19:50:39 | |
In reply to @hexa:lossy.networkGiven it unblocks those packages, I was starting to think we should just go ahead and merge the npmRoot PR and do further review items in follow-up PRs (and backport post branchoff) | 20:43:35 | |
I would like npmRoot, I was just still wondering if we wanted it on the other hooks so that it worked with buildNpmPackage and wondering if we wanted it also on fetchNpmDeps. But that doesn't need to be a blocker | 20:44:37 | |
| Did the npmRoot change work for botamusique? Because it caused problems with navidrome. | 20:44:41 | |
In reply to @hexa:lossy.networkOh really? I hadn't tested yet | 20:44:55 | |
| https://github.com/NixOS/nixpkgs/pull/230991#issuecomment-1552133508 | 20:45:17 | |
In reply to @hexa:lossy.networkWeird 🤔 | 20:46:07 | |
| I'll investigate in like ~1-2 hours (sorry for delays, day ended up with more non-computer things to do than I thought) | 20:46:45 | |
| No worries, this is a hobby after all | 20:47:25 | |
In reply to @hexa:lossy.network I cannot replicate this by cherry-picking your commit from #229953 on top of #230991 and adding this diff:
| 21:31:44 | |
Instead I just get a successfully built /nix/store/0qjbbmqfvgn9x4g9rgyvbqsfzj9bda91-navidrome-0.49.3 | 21:32:36 | |
Also the navidrome update script fails because building .go-modules in general on the derivation fails due to buildGoModule propagating nativeBuildInputs to the fetcher (???) which obviously adds the npm hook which when run, expects to be building npm stuff, not fetching go modules | 21:38:51 | |