!NhAsaYbbgmzHtXTPQJ:funklause.de

Nix NodeJS

201 Members
56 Servers

Load older messages


SenderMessageTime
19 May 2023
@denbrahe:matrix.orgdenbrahe Lily Foster: were you able to work on a solution for retrying package downloads with buildNpmPackage and prefetch-npm-deps already? 16:12:32
@lily:lily.flowersLily Foster
In reply to @denbrahe:matrix.org
Lily Foster: were you able to work on a solution for retrying package downloads with buildNpmPackage and prefetch-npm-deps already?

Yes I've worked on it. I actually found that switching out the ureq library that prefetch-npm-deps is using with something else (e.g. minreq) caused the issues to stop occuring for me

We were wanting to have it use isahc instead, but that library was giving us issues with certs for some reason that I haven't had the time to dive into yet

I'll let you know when we have more, because the random request failures on poor internet connections thing is annoying

16:58:33
@denbrahe:matrix.orgdenbraheOh, that sounds great! Let me know if I can help with testing or something else!17:01:06
21 May 2023
@hexa:lossy.networkhexahow are we progressing on the npm PRs? branch-off is now really close14:20:18
@lily:lily.flowersLily Fosterhttps://github.com/NixOS/nixpkgs/pull/206477 is still ready for review and I planned to get back to the npmRoot PR today14:23:22
@lily:lily.flowersLily Foster(Probably in ~3-4 hours)14:23:43
@raitobezarius:matrix.orgraitobezarius Lily Foster: the PR is good to go IMHO 14:36:54
@lily:lily.flowersLily FosterConfirmed with Winter and merged it 🎉15:17:28
@lily:lily.flowersLily FosterI tested the heck out of it but will still watch the next hydra eval for regressions just in case15:17:57
@raitobezarius:matrix.orgraitobezariusyeah you have some stabilization days ahead of you if needed :)15:25:46
@raitobezarius:matrix.orgraitobezariusI have been dreaming those last days about starting the yarn backend for buildNpmPackage15:25:55
@raitobezarius:matrix.orgraitobezariushopefully when the branch off is done and things becomes calmer on QEMU, I will do that :)15:26:10
@raitobezarius:matrix.orgraitobezarius * hopefully when the ~branch off~ release is done and things becomes calmer on QEMU, I will do that :)15:26:19
@lily:lily.flowersLily Foster
In reply to @raitobezarius:matrix.org
yeah you have some stabilization days ahead of you if needed :)
Don't we all
15:26:38
@raitobezarius:matrix.orgraitobezariusyes :D15:27:00
@lily:lily.flowersLily Foster
In reply to @raitobezarius:matrix.org
I have been dreaming those last days about starting the yarn backend for buildNpmPackage
I've a few open yarn PRs to help that and there's a draft buildYarnPackage too we'll pick up soon
15:27:05
@hexa:lossy.networkhexaand https://github.com/NixOS/nixpkgs/pull/230991? 😲19:50:04
@hexa:lossy.networkhexashould we merge botamusique and navidrome with the npmCOnfigHook reschedule hack?19:50:34
@hexa:lossy.networkhexa * should we merge botamusique and navidrome with the npmConfigHook reschedule hack?19:50:39
@lily:lily.flowersLily Foster
In reply to @hexa:lossy.network
should we merge botamusique and navidrome with the npmConfigHook reschedule hack?
Given it unblocks those packages, I was starting to think we should just go ahead and merge the npmRoot PR and do further review items in follow-up PRs (and backport post branchoff)
20:43:35
@lily:lily.flowersLily Foster I would like npmRoot, I was just still wondering if we wanted it on the other hooks so that it worked with buildNpmPackage and wondering if we wanted it also on fetchNpmDeps. But that doesn't need to be a blocker 20:44:37
@hexa:lossy.networkhexaDid the npmRoot change work for botamusique? Because it caused problems with navidrome.20:44:41
@lily:lily.flowersLily Foster
In reply to @hexa:lossy.network
Did the npmRoot change work for botamusique? Because it caused problems with navidrome.
Oh really? I hadn't tested yet
20:44:55
@hexa:lossy.networkhexahttps://github.com/NixOS/nixpkgs/pull/230991#issuecomment-155213350820:45:17
@lily:lily.flowersLily Foster
In reply to @hexa:lossy.network
https://github.com/NixOS/nixpkgs/pull/230991#issuecomment-1552133508
Weird 🤔
20:46:07
@lily:lily.flowersLily FosterI'll investigate in like ~1-2 hours (sorry for delays, day ended up with more non-computer things to do than I thought)20:46:45
@hexa:lossy.networkhexaNo worries, this is a hobby after all 20:47:25
@lily:lily.flowersLily Foster
In reply to @hexa:lossy.network
https://github.com/NixOS/nixpkgs/pull/230991#issuecomment-1552133508

I cannot replicate this by cherry-picking your commit from #229953 on top of #230991 and adding this diff:

diff --git a/pkgs/servers/misc/navidrome/default.nix b/pkgs/servers/misc/navidrome/default.nix
index 7c121e82210..309601e059f 100644
--- a/pkgs/servers/misc/navidrome/default.nix
+++ b/pkgs/servers/misc/navidrome/default.nix
@@ -28,22 +28,14 @@ buildGoModule rec {
 
   vendorHash = "sha256-C8w/qCts8VqNDTQVXtykjmSbo5uDrvS9NOu3SHpAlDE=";
 
+  npmRoot = "ui";
+
   npmDeps = fetchNpmDeps {
     inherit src;
     sourceRoot = "source/ui";
     hash = "sha256-qxwTiXLmZnTnmTSBmWPjeFCP7qzvTFN0xXp5lFkWFog=";
   };
 
-  prePatch = ''
-    postPatchHooks=("''${postPatchHooks[@]/npmConfigHook}")
-  '';
-
-  postPatch = ''
-    pushd ui
-    npmConfigHook
-    popd
-  '';
-
   nativeBuildInputs = [
     makeWrapper
     nodejs
21:31:44
@lily:lily.flowersLily Foster Instead I just get a successfully built /nix/store/0qjbbmqfvgn9x4g9rgyvbqsfzj9bda91-navidrome-0.49.3 21:32:36
@lily:lily.flowersLily Foster Also the navidrome update script fails because building .go-modules in general on the derivation fails due to buildGoModule propagating nativeBuildInputs to the fetcher (???) which obviously adds the npm hook which when run, expects to be building npm stuff, not fetching go modules 21:38:51

There are no newer messages yet.


Back to Room ListRoom Version: 6