In reply to @p14:matrix.org
Artturin: I also tried building pkgsStatic.pkgsLLVM.clang.cc -- for this I hit the error message you described in https://github.com/NixOS/nixpkgs/issues/22060 ( file RPATH_CHANGE could not write new RPATH:) while in the ninja install phase of llvm.

Needed this to fix cmake builds though, does it seem reasonable?

diff --git a/pkgs/stdenv/adapters.nix b/pkgs/stdenv/adapters.nix
index f29bdf671c8c..dbc80e6bfbe0 100644
--- a/pkgs/stdenv/adapters.nix
+++ b/pkgs/stdenv/adapters.nix
@@ -64,8 +64,9 @@ rec {
         configureFlags = (finalAttrs.configureFlags or []) ++ [
-            "--disable-shared" # brrr...
-          ];
+          "--disable-shared" # brrr...
+        ];
+        cmakeFlags = (finalAttrs.cmakeFlags or []) ++ ["-DCMAKE_SKIP_INSTALL_RPATH=On"];
       }));
     } // lib.optionalAttrs (stdenv0.hostPlatform.libc == "glibc") {

In reply to @p14:matrix.org

Needed this to fix cmake builds though, does it seem reasonable?

diff --git a/pkgs/stdenv/adapters.nix b/pkgs/stdenv/adapters.nix
index f29bdf671c8c..dbc80e6bfbe0 100644
--- a/pkgs/stdenv/adapters.nix
+++ b/pkgs/stdenv/adapters.nix
@@ -64,8 +64,9 @@ rec {
         configureFlags = (finalAttrs.configureFlags or []) ++ [
-            "--disable-shared" # brrr...
-          ];
+          "--disable-shared" # brrr...
+        ];
+        cmakeFlags = (finalAttrs.cmakeFlags or []) ++ ["-DCMAKE_SKIP_INSTALL_RPATH=On"];
       }));
     } // lib.optionalAttrs (stdenv0.hostPlatform.libc == "glibc") {

In reply to @p14:matrix.org
Artturin: What next? Any opinion as to whether it may go into staging?

In reply to @p14:matrix.org
Artturin: What next? Any opinion as to whether it may go into staging?

In reply to @artturin:matrix.org
superficially ok but put it in a separate PR

In reply to @p14:matrix.org
Is that one (the makeStaticBinaries change) for staging or master do you think?

Ah, darn, that hits the infinite recursion with the comment (following); so I guess the 'bug' here is merely that I was mislead by it being called finalAttrs.

# An infinite recursion here can be caused by having the attribute names of expression ein.overrideAttrs(finalAttrs: previousAttrs: e)depend onfinalAttrs. Only the attribute values of ecan depend onfinalAttrs.

In reply to @artturin:matrix.org
ofborg will probably show <500 rebuilds but it'll rebuild everything pkgsStatic so do staging

A question about static builds. How are the -l libraries meant to work in principle? By way of an example, git fails to build properly because when it links -lcurl, it has missing symbols for curl's transitive dependencies. I guess this is a case that would be solved by pkgconfig --static which would use the Private fields from a pkgconfig/*.pc file, but I observe that even those often fail to correctly list the libraries required for linking.

So, is this a solved problem somewhere? Do I just bodge NIX_LDFLAGS with extra -l libraries, or is there some other way that software being built is meant to discover what -l flags it should use?

In reply to @p14:matrix.org

A question about static builds. How are the -l libraries meant to work in principle? By way of an example, git fails to build properly because when it links -lcurl, it has missing symbols for curl's transitive dependencies. I guess this is a case that would be solved by pkgconfig --static which would use the Private fields from a pkgconfig/*.pc file, but I observe that even those often fail to correctly list the libraries required for linking.

So, is this a solved problem somewhere? Do I just bodge NIX_LDFLAGS with extra -l libraries, or is there some other way that software being built is meant to discover what -l flags it should use?

makeStatic should already be converting buildInputs to propagatedBuildInputs
https://github.com/NixOS/nixpkgs/blob/e89bfed9d701b753be10bbf2790cb8b3032fff04/pkgs/stdenv/adapters.nix#L119

but it probably wont help if the pc file is missing stuff