Nixpkgs Stdenv | 220 Members | |
| 71 Servers |
| Sender | Message | Time |
|---|---|---|
| 21 Jan 2025 | ||
| I didn’t call it out in my comments, but I think there was at least one that looked like it would evaluate differently after the change. | 16:57:31 | |
In reply to @rosscomputerguy:matrix.orgI didn’t see a reply to my comment, but that takes care of it. Thanks! | 16:58:09 | |
The only other possibility is some of the useLLVM logic that was converted now evaluates to true on Darwin. If something is getting new/additional CMake flags, that would cause rebuilds. | 16:58:35 | |
| Also, I think changing the order of flags can cause rebuilds. | 16:59:12 | |
Though looking at compiler-rt, I think it’s more the former. Those flags are probably fine, but if you want to target master, they would need a !stdenv.hostPlatform.isDarwin that could be dropped to enable them in staging. | 17:00:58 | |
| Yeah, I need to run a nix-diff to figure things out | 17:01:15 | |
I think this can just go to staging… bootstrap changes will almost certainly have to go through there anyway | 17:01:21 | |
| I just don't have time right now lol | 17:01:22 | |
| it's not like it will result in any urgent behaviour fixes | 17:01:44 | |
| (though of course we should make sure that any builds it changes get more correct) | 17:01:50 | |
I’d just like all the conditionals to be simplified. If unwinderlib is being checked for libgcc_s, that should never be true on Darwin. If it ever is, then maybe that conditional should be enabled. | 17:02:29 | |
The extra granularity should help clean things up a lot instead of having useLLVM && (not three or four platforms). | 17:02:50 | |
| But I didn’t suggest more of those changes to keep the scope simple for now. | 17:03:23 | |
In reply to @emilazy:matrix.orgThe thing is, this is supposed to be like a semantics change | 17:03:48 | |
| So that shouldn't cause rebuilds | 17:03:56 | |
right. but along the way we are likely to discover that some useLLVM conditionals were wrong. so we should at least fix those (but doing that separately on staging is fine too) | 17:04:33 | |
(precisely because Darwin is almost entirely useLLVM but not included in it) | 17:04:42 | |
| 22 Jan 2025 | ||
| Rebuild counts are going down yay | 03:34:12 | |
| I'll try to give it a proper re-review in the next day or two | 03:40:41 | |
Rebuild count is down to nothing now, only 3 because of references to the lib directory's path. | 04:31:18 | |
| 23 Jan 2025 | ||
| 01:24:26 | ||
| 08:09:16 | ||
| While I'm waiting for reviews, I've decided to resurrect the CPU model PR I had and start fresh. https://github.com/NixOS/nixpkgs/pull/376197 this is very WIP. | 19:22:53 | |
| 30 Jan 2025 | ||
| Is this the right place to ask about adding a boot GHC to tarballs.nixos.org for RISC-V? (This was also asked back in 2024-09 but it was slightly too early back then.) | 15:25:04 | |
In reply to @alex:tunstall.xyzI don't have any real negativity towards it. I can see how it would be useful. | 17:54:24 | |
| But how much maintenance does it require? Would we drop it once upstream does? | 17:55:03 | |
| How big would we expect the GHC bootstrap to be? Which versions should we support? | 17:55:50 | |
| The bare minimum would be one for the oldest GHC release that Nixpkgs wants to support. We could drop the tarball once upstream provide a tarball that can build all Nixpkgs supported versions, or at the very least the active Nixpkgs default. GHC tarballs tend to be quite large, but if necessary, we can configure the build to be the bare minimum needed to boot GHC and make them much smaller. | 19:05:39 | |
| 19:45:34 | ||
| 31 Jan 2025 | ||
| 19:34:42 | ||