| 10 Apr 2025 |
 Tristan Ross | Yeah, that's why I tested things here. | 19:06:23 |
| Tristan Ross | openssl and expect both fail in the fixupPhase but key-utils itself actually has a problem. | 19:06:50 |
| Tristan Ross | It's likely we won't see the downstream effect of the const char* stuff until a long time from now but working on the problem sooner than later may not be a bad idea. | 19:07:30 |
| Tristan Ross | Aaron Ballman is who I've been on contact with for this btw. | 19:08:12 |
 Alyssa Ross | Yeah | 19:08:15 |
| Alyssa Ross | We could maybe have a low-activity Hydra jobset? | 19:08:24 |
| Tristan Ross | Yeah, that may not be a bad idea | 19:08:36 |
| Alyssa Ross | Great that you're involved in this so proactively | 19:08:59 |
| Tristan Ross | As a quick and dirty way to get started, I just did this:
diff --git a/pkgs/build-support/cc-wrapper/default.nix b/pkgs/build-support/cc-wrapper/default.nix
index 692474d48c42..262594e6dd15 100644
--- a/pkgs/build-support/cc-wrapper/default.nix
+++ b/pkgs/build-support/cc-wrapper/default.nix
@@ -845,6 +845,10 @@ stdenvNoCC.mkDerivation {
substituteAll ${./add-clang-cc-cflags-before.sh} $out/nix-support/add-local-cc-cflags-before.sh
''
+ + ''
+ echo "-Werror=write-strings" >> $out/nix-support/cc-cflags
+ ''
+
##
## Extra custom steps
##
| 19:08:59 |
| Alyssa Ross | Yeah I'd just throw that up on a branch and get Hydra on it for now | 19:09:30 |
| Alyssa Ross | I'm not sure whether we'd want to enable this for real before compilers start doing so | 19:11:46 |
| Alyssa Ross | But getting a head start is good | 19:11:51 |
 emily | agreed that preparing for this stuff ahead of time is great :) | 19:12:06 |
| emily | I wish we had the resources to have an "experimental" jobset always running that we could throw stuff like this on | 19:12:27 |
| emily | rather than dealing with things just-in-time during staging cycles | 19:12:35 |
| Alyssa Ross | It's the sort of thing that somebody could probably run on a personal Hydra if they wanted I reckon? We don't need the results particularly fast given the bottleneck is actually going to be manually fixing things one at a time. | 19:13:44 |
