| 5 Jan 2025 |
emily | anyway, like I said enough of a task that it shouldn't block incremental improvements :) | 19:05:47 |
emily | but I don't think it would be an immense amount of implementation work and the benefits would be huge | 19:06:02 |
connor (burnt/out) (UTC-8) | Wouldn’t that change need to be backported through Nix 2.3? | 19:48:29 |
connor (burnt/out) (UTC-8) | * Wouldn’t such changes need to be backported through Nix 2.3? | 19:49:40 |
emily | I don't think so – spammy build output isn't a compatibility break | 19:50:36 |
emily | (but we should bump minver to 2.18 anyway, it was discussed on a recent structured attributes PR…) | 19:50:46 |
| 6 Jan 2025 |
emily | how does stdenvNoCC get defined? I see a bunch of stdenvNoCC =s, of course, but I can't tell where the magic to stop it having a cc happens. | 18:40:34 |
emily | (in particular, I want to know one can condition the extraBuildInputs on cc-ness) | 18:41:32 |
Artturin | https://github.com/NixOS/nixpkgs/blob/a8af4a1033a3ab6d14d37731512ecd8bbf39c2b9/pkgs/top-level/stage.nix#L54
https://github.com/NixOS/nixpkgs/blob/a8af4a1033a3ab6d14d37731512ecd8bbf39c2b9/pkgs/top-level/stage.nix#L148
https://github.com/NixOS/nixpkgs/blob/a8af4a1033a3ab6d14d37731512ecd8bbf39c2b9/pkgs/top-level/stage.nix#L354 | 19:46:03 |
emily | thanks | 19:47:57 |
Artturin | https://github.com/NixOS/nixpkgs/blob/a8af4a1033a3ab6d14d37731512ecd8bbf39c2b9/pkgs/top-level/default.nix#L153-L157
https://github.com/NixOS/nixpkgs/blob/a8af4a1033a3ab6d14d37731512ecd8bbf39c2b9/pkgs/stdenv/booter.nix#L100
stdenv comes from here maybe | 19:48:09 |
emily | I guess the per-platform bootstrap stages don't necessarily know whether cc is going to be set in the stdenv? 🤔 | 19:48:16 |
emily | right now we do this kind of thing
thisStdenv = import ../generic {
name = "${name}-stdenv-darwin";
buildPlatform = localSystem;
hostPlatform = localSystem;
targetPlatform = localSystem;
inherit config;
extraBuildInputs = [ prevStage.apple-sdk ];
inherit extraNativeBuildInputs;
| 19:48:50 |
emily | but including the SDK in stdenvNoCC pulls in a bunch of stuff | 19:49:02 |
Randy Eckenrode | Did the old stdenvNoCC include CoreFoundation? | 19:53:05 |
Randy Eckenrode | It’s picking up extraBuildPackages? | 19:53:28 |
Randy Eckenrode | * It’s picking up extraBuildInputs? | 19:53:40 |
emily | https://github.com/NixOS/nixpkgs/issues/371465 | 19:54:30 |
Randy Eckenrode | I saw the issue. Was this not a problem no one noticed before because it was just the CoreFoundation headers and stubs? | 19:55:11 |
Randy Eckenrode | * | 19:55:41 |
Randy Eckenrode | The SDK pulls in a toolchain because it symlinks some stuff in $DEVELOPER_DIR/usr/bin because Chromium. | 19:57:06 |
Randy Eckenrode | Isn’t the easy fix to drop extraBuildInputs on Darwin? | 19:57:40 |
Randy Eckenrode | * Isn’t the easy fix to drop extraBuildInputs from stdenvNoCC on Darwin? | 19:57:56 |
emily | yes | 19:58:31 |
emily | I was trying to figure out how to do this | 19:58:34 |
emily | https://github.com/NixOS/nixpkgs/pull/371539 it evals, trying a build on x86_64-darwin, looks like there's some unrelated darwin.libffi fallout on AArch64 | 20:00:53 |
| 7 Jan 2025 |
Toma | Would appreciate some feedback
https://github.com/NixOS/nixpkgs/pull/371613
this is partially based on some earlier conversations which I don't have the time to find right now, but I think amjoseph was part of it | 00:19:15 |
emily | oh I will have a lot of opinions about this | 00:20:49 |
emily | fwiw there is also https://github.com/NixOS/nixpkgs/pull/296769 | 00:21:05 |
emily | my #1 request: do the depsInPath/deps thing, but make them attribute sets, and have overrides work by the name | 00:21:59 |