| 2 Mar 2024 |
| Qyriad joined the room. | 19:34:40 |
| 3 Mar 2024 |
Philip Taron (UTC-8) | stdenv folks, Qyriad concocted a PR which really helps make the stdenv hooks more self-documenting. I've reviewed it, and while more eyes would definitely be better, having built my NixOS system with it, I think it's good to go.
What's needed in order to get it either further reviewed or merged?
| 23:00:03 |
| 4 Mar 2024 |
Puna | In reply to @trofi:matrix.org Let's start from a tiny https://github.com/NixOS/nixpkgs/pull/288250 thanks! adding the entry to the file now, so the original PR can go back to referring to Hydra build results and use your script for requesting an upload: https://github.com/NixOS/nixpkgs/pull/293257 | 14:07:46 |
| 9 Mar 2024 |
Philip Taron (UTC-8) | Qyriad: did you see a-n-n-a-l-e-e 's comment on your merged PR? | 01:47:16 |
Qyriad | I did just now | 01:49:09 |
Qyriad | That is correct behavior for how the change was designed — it outputs just as part of the build log, just like phase headers do | 01:50:03 |
Qyriad | nix-shell -p doing that is kind of an artifact of the cursed way nix-shell is implemented — personally I would argue this is a good thing, and makes it more transparent that nix-shell is a derivation that relies on hooks to make it work | 01:51:32 |
Qyriad | though I suppose it is a lot of output for a common operation | 01:51:42 |
@a-n-n-a-l-e-e:matrix.org | Redacted or Malformed Event | 01:54:08 |
@a-n-n-a-l-e-e:matrix.org | $ nix-shell -I nixpkgs=. -p bash --run "exit"|wc -l
104
104 lines of output from the new logging.
| 01:55:16 |