| 15 Nov 2024 |
 p14 | But it's only a warning right now so not especially motivated to fix a single package. | 09:20:22 |
| p14 | Though, is this the kind of thing that can even be done treewide? :hmm: | 09:20:39 |
 emily | that was just being talked about in the dev room | 09:21:41 |
| p14 | Failing at first hurdle here emily - I was under the impression nostdinc was somehow conditioned on the target, or that darwin had a fix for it somehow, but I see it unconditionally here: https://github.com/NixOS/nixpkgs/blob/52bf1163fadb7ee5e21ee0b8e5cf266acb3e74e9/pkgs/development/compilers/llvm/common/default.nix#L533 | 09:21:52 |
| emily | I think yes as long as the people who do it actually show up to the staging-next cycle to fix everything | 09:22:00 |
| emily | because there'll be a lot to fix | 09:22:05 |
| emily | In reply to @p14:matrix.org
Failing at first hurdle here emily - I was under the impression nostdinc was somehow conditioned on the target, or that darwin had a fix for it somehow, but I see it unconditionally here: https://github.com/NixOS/nixpkgs/blob/52bf1163fadb7ee5e21ee0b8e5cf266acb3e74e9/pkgs/development/compilers/llvm/common/default.nix#L533 that commit is before the staging-next merge from ~yesterday | 09:22:51 |
| emily | which is where I added the conditional | 09:22:56 |
| emily | (to unbreak Darwin stuff) | 09:23:01 |
| p14 | Gotcha. | 09:23:03 |
| emily | FWIW, the condition is Darwin host and Darwin target, but we can probably relax that to Darwin target. | 09:23:21 |
| emily | there's some iffiness around using the compiler outside the sandbox without an SDK to do Linux-to-Darwin cross but… eh… | 09:23:40 |
| emily | Linux-to-Darwin cross doesn't even work yet for one | 09:23:56 |
| emily | and when it does the divergence will become annoying | 09:24:00 |
| p14 | https://matrix.to/#/!ayCRiZriCVtuCUpeLp:nixos.org/$qpO1aqKQfb-3zGKi_wHlLgQ-nCND4chY_Tc5kHQHqNQ?via=nixos.org&via=matrix.org&via=tchncs.de was just asking about linux-to-darwin cross. I was under the impression it isn't possible. Is there a way? | 09:24:29 |
| emily | I'll reply there :) | 09:25:03 |
| p14 | In reply to @emilazy:matrix.org
should maybe just send this to staging so you can do the --replace-fail thing? I sent this as a separate patch. https://github.com/NixOS/nixpkgs/pull/356120 | 09:52:50 |
| p14 | Currently untested while I await a bunch of staging to build. Is there some automated on-PR testing available? | 09:53:30 |
| emily | don't you mean --replace-fail '--replace ' '--replace-fail '? | 09:54:56 |
| emily | In reply to @p14:matrix.org
Currently untested while I await a bunch of staging to build. Is there some automated on-PR testing available? ofborg does build staging PRs. | 09:55:05 |
| emily | I'd be happy to just hit the button on this though. | 09:55:27 |
| emily | I'm going to bootstrap a Darwin stdenv on the latest staging in the next day or so. | 09:55:36 |
| emily | so if it breaks I know who to complain to | 09:55:44 |
| emily | this will break the Git LLVM without that other PR, though, right? | 09:55:51 |
| emily | those test failures didn't seem like they ought to be related to me | 09:55:57 |
| p14 | Agree with everything you said. | 09:56:09 |
| emily | In reply to @p14:matrix.org
Currently untested while I await a bunch of staging to build. Is there some automated on-PR testing available? another thing you can/should do is base your PR on git merge-base upstream/master upstream/staging | 09:56:26 |
| emily | which lets you target staging but get master amounts of rebuilds for testing | 09:56:38 |
| emily | (of course you don't test its combination with other staging changes but it's better than nothing) | 09:56:54 |
| p14 | It doesn't apply on that unfortunately | 09:57:03 |
