| 19 May 2025 |
 emily | failing that, the easiest thing is probably just to find whatever commit dropped the use and backport it | 13:27:14 |
| emily | we backport half of new LLVMs to old ones anyway… | 13:27:20 |
 hexa | fair | 13:27:39 |
| 20 May 2025 |
| hexa | https://github.com/llvm/llvm-project/commit/a48f018bb7d8fadc67c08e71409c31713daa0071#diff-1ea3be0bb9b548162196ebb34bbae2fc2bf7bff6f3385113f184e8a998f4a78a | 01:31:30 |
| hexa | removed here in 16.0.0-rc1 | 01:31:43 |
| emily | "Now that all jobs have moved over to the new style of Lit configuration, we can remove all traces of the legacy testing configuration system." is not promising for backportability | 01:37:05 |
| emily | maybe patching the shebang on lit will help? | 01:37:35 |
| emily | or could just disable tests for those old versions. or let them break and see how much people really care about old LLVMs. | 01:37:49 |
| hexa | the first estimate is ~115 packages in the python scope per platform | 01:41:03 |
| emily | it looks like it's only for libcxx and libunwind | 01:40:43 |
| hexa | diff --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index eb55c03a7687..9266c53be750 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -9,7 +9,6 @@
import copy
import os
import pkgutil
-import pipes
import platform
import re
import shlex
@@ -434,7 +433,7 @@ class Configuration(object):
def quote(self, s):
if platform.system() == 'Windows':
return lit.TestRunner.quote_windows_command([s])
- return pipes.quote(s)
+ return shlex.quote(s)
def configure_substitutions(self):
sub = self.config.substitutions
| 01:42:45 |
| emily | * it looks like it's only for libcxx and libunwind? | 01:40:43 |
| hexa | * diff --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index eb55c03a7687..9266c53be750 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -9,7 +9,6 @@
import copy
import os
import pkgutil
-import pipes
import platform
import re
import shlex
@@ -434,7 +433,7 @@ class Configuration(object):
def quote(self, s):
if platform.system() == 'Windows':
return lit.TestRunner.quote_windows_command([s])
- return pipes.quote(s)
+ return shlex.quote(s)
def configure_substitutions(self):
sub = self.config.substitutions
| 01:42:48 |
| emily | I think we can disable tests on old versions of those. | 01:40:43 |
| hexa | this could be all that's needed | 01:42:57 |
| hexa | do I start contributing to llvm now? 😫 | 01:43:36 |
| hexa | also tblgen iirc, but i'd have to check | 01:44:14 |
| emily | they don't maintain the old versions at all | 01:43:49 |
| hexa | hm no | 01:45:31 |
| emily | everything but 20 is technically EOL | 01:43:57 |
| hexa | ah, great | 01:47:13 |
| emily | which is also why as many of them as possible should go away in 25.11 | 01:44:12 |
| emily | so some of those Python packages may be casualties anyway | 01:44:22 |
| hexa | https://github.com/numba/llvmlite | 01:48:09 |
| hexa | I'm frankly not sure why they lag behind that much | 01:48:24 |
| emily | LLVM does a fair amount of breaking changes I think. | 01:50:39 |
| emily | you're meant to upstream things | 01:51:13 |
| emily | fwiw they apparently have experimental LLVM 16 support | 01:52:53 |
| emily | from the Fedora package:
# For 0.44.0, LLVM 15 is the default. LLVM 16 support is “experimental;” we can
# try it if we need to.
| 01:53:00 |
| hexa | ok, neat | 01:54:33 |
