!OqhvaDMJdKYUicLDiE:nixos.org

Nixpkgs Stdenv

233 Members
75 Servers

Load older messages


SenderMessageTime
18 Feb 2023
@sielicki:matrix.orgsielicki joined the room.19:04:15
@sielicki:matrix.orgsielickiHas anyone taken a look at integrating with https://libc.llvm.org/ in overlay mode?19:04:30
20 Feb 2023
@tpw_rules:matrix.orgtpw_rules joined the room.02:34:23
@tpw_rules:matrix.orgtpw_rules
In reply to @vcunat:matrix.org
aarch64-linux gcc bootstrap:
https://github.com/NixOS/nixpkgs/pull/207135#issuecomment-1415896172
I think this is ready to go? upload needs to be done
02:39:14
@vcunat:matrix.orgvcunat
In reply to @tpw_rules:matrix.org
I think this is ready to go? upload needs to be done
Yes, I'm waiting for the upload. I don't have permissions. I asked two different people already.
07:52:53
@artturin:matrix.orgArtturinstructuredAttrs related https://github.com/NixOS/nixpkgs/pull/21720616:39:37
21 Feb 2023
@trofi:matrix.orgtrofi Did you know make install is not running in parallel in nixpkgs? https://github.com/NixOS/nixpkgs/pull/217568 21:56:32
@qyliss:fairydust.spaceAlyssa RossI'd been wondering about that21:58:03
@qyliss:fairydust.spaceAlyssa Rossalso because of openssl21:58:11
24 Feb 2023
@artturin:matrix.orgArtturin

https://github.com/NixOS/nixpkgs/pull/76732#issuecomment-1442172547

Was having lists in env automatically have toString run on them ever considered?

04:31:34
@artturin:matrix.orgArtturin
nix-repl> (keepassxc.overrideAttrs(oA: { passthru.oA = oA; })).oA.env.NIX_CFLAGS_COMPILE
[ "-Wno-old-style-cast" "-Wno-error" "-D__BIG_ENDIAN__=0" ]

nix-repl> keepassxc.NIX_CFLAGS_COMPILE
"-Wno-old-style-cast -Wno-error -D__BIG_ENDIAN__=0"

nix-repl> (keepassxc.overrideAttrs(oA: { passthru.oA = oA; })).oA.NIX_CFLAGS_COMPILE
error:
       … while evaluating the attribute 'oA.NIX_CFLAGS_COMPILE'

         at «string»:1:32:

            1| (keepassxc.overrideAttrs(oA: { passthru.oA = oA; })).oA.NIX_CFLAGS_COMPILE
             |                                ^

       error: attribute 'NIX_CFLAGS_COMPILE' missing

       at «string»:1:1:

            1| (keepassxc.overrideAttrs(oA: { passthru.oA = oA; })).oA.NIX_CFLAGS_COMPILE
             | ^
04:42:20
@artturin:matrix.orgArtturinthat would allow appending nicely in overrideAttrs04:42:38
@artturin:matrix.orgArtturin
diff --git a/pkgs/applications/misc/keepassxc/default.nix b/pkgs/applications/misc/keepassxc/default.nix
index 3c74b6e9175..158ffe5fc8d 100644
--- a/pkgs/applications/misc/keepassxc/default.nix
+++ b/pkgs/applications/misc/keepassxc/default.nix
@@ -49,11 +49,11 @@ stdenv.mkDerivation rec {
     sha256 = "sha256-amedKK9nplLVJTldeabN3/c+g/QesrdH+qx+rba2/4s=";
   };
 
-  env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang (toString [
+  env.NIX_CFLAGS_COMPILE = lib.optionals true [
     "-Wno-old-style-cast"
     "-Wno-error"
     "-D__BIG_ENDIAN__=${if stdenv.isBigEndian then "1" else "0"}"
-  ]);
+  ];
 
   NIX_LDFLAGS = lib.optionalString stdenv.isDarwin "-rpath ${libargon2}/lib";
 
diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix
index 3d60934557c..fc36edf9ee4 100644
--- a/pkgs/stdenv/generic/make-derivation.nix
+++ b/pkgs/stdenv/generic/make-derivation.nix
@@ -537,8 +537,8 @@ else let
     assert lib.assertMsg (overlappingNames == [ ])
       "The ‘env’ attribute set cannot contain any attributes passed to derivation. The following attributes are overlapping: ${lib.concatStringsSep ", " overlappingNames}";
     lib.mapAttrs
-      (n: v: assert lib.assertMsg (lib.isString v || lib.isBool v || lib.isInt v || lib.isDerivation v)
-        "The ‘env’ attribute set can only contain derivation, string, boolean or integer attributes. The ‘${n}’ attribute is of type ${builtins.typeOf v}."; v)
+      (n: v: assert lib.assertMsg (lib.isString v || lib.isBool v || lib.isInt v || lib.isDerivation v || lib.isList v)
+        "The ‘env’ attribute set can only contain derivation, list, string, boolean or integer attributes. The ‘${n}’ attribute is of type ${builtins.typeOf v}."; (if lib.isList v then toString v else v))
       env;
 
 in
04:42:47
@artturin:matrix.orgArtturinhttps://github.com/NixOS/nixpkgs/pull/21796204:52:20
3 Mar 2023
@artturin:matrix.orgArtturinhttps://github.com/NixOS/nixpkgs/pull/21918215:09:21
7 Mar 2023
@winterqt:nixos.devWinter (she/her)
[nix-shell:~]$ which hello
/nix/store/nfzcdd26n8qs7dyh6kwz2hmp9rkppdcg-hello-2.12.1/bin/hello

[nix-shell:~]$ patchelf --print-needed /nix/store/nfzcdd26n8qs7dyh6kwz2hmp9rkppdcg-hello-2.12.1/bin/hello
libc.so.6
ld-linux-aarch64.so.1

anyone know why we add ldso to needed for (as far as I can tell) just aarch64? i can't get the same result on x86_64-linux, and I don't see any extra flags added via ld-wrapper that would cause this.

01:44:35
@winterqt:nixos.devWinter (she/her) *
[nix-shell:~]$ which hello
/nix/store/nfzcdd26n8qs7dyh6kwz2hmp9rkppdcg-hello-2.12.1/bin/hello

[nix-shell:~]$ patchelf --print-needed /nix/store/nfzcdd26n8qs7dyh6kwz2hmp9rkppdcg-hello-2.12.1/bin/hello
libc.so.6
ld-linux-aarch64.so.1

anyone know why/where we add ldso to needed for (as far as I can tell) just aarch64? i can't get the same result on x86_64-linux, and I don't see any extra flags added via ld-wrapper that would cause this.

01:44:46
@winterqt:nixos.devWinter (she/her) e.g. grepped NIX_DEBUG=7 logs and cannot find anything that would do this 02:19:48
@trofi:matrix.orgtrofi patchelf --set-interpreter 07:18:50
@trofi:matrix.orgtrofi lddtree from pax-utils might make it more obvious where ld.so comes from. 07:19:15
@trofi:matrix.orgtrofi ld.wrapper sets it in pkgs/build-support/bintools-wrapper/ld-wrapper.sh: extraBefore+=("-dynamic-linker" "$NIX_DYNAMIC_LINKER_@suffixSalt@") 07:20:01
@winterqt:nixos.devWinter (she/her)
In reply to @trofi:matrix.org
patchelf --set-interpreter
i don't think that's true entirely (either that or patchelf is bugged on aarch64)? x86_64-linux also has the interpreter set, but patchelf --print-needed does not show it.
12:41:29
@winterqt:nixos.devWinter (she/her)which is why i ask, it just seems strange and nonobvious12:41:49
@winterqt:nixos.devWinter (she/her) (by "true entirely" i mean that doesn't explain what i'm seeing here) 12:44:50
@winterqt:nixos.devWinter (she/her)i checked an aarch64-linux binary not from Nixpkgs and it doesn't have the interpreter in print-needed either, so i think that rules out being a patchelf issue12:45:54
@winterqt:nixos.devWinter (she/her)i just don't know where else the interpreter would get added to needed other than in ld-wrapper, and i do not see it there12:46:30
@winterqt:nixos.devWinter (she/her)just seems very very strange that this is only happening on aarch64 🙃12:54:05
@winterqt:nixos.devWinter (she/her) apologies for the maybe nonsensical rambling trofi, but hopefully those clarifications make the issue(?) clear that it's not the interpreter i'm talking about. i really don't know where to go from here, though, so any help is appreciated. thank you! 15:37:24
@trofi:matrix.orgtrofiDo you have an 'lddtree' output on problematic file? Does it show ldso output anywhere except the interpreter?17:45:31
@trofi:matrix.orgtrofiI generally have less faith in patchelf than readelf or objdump when it comes to parsing elves.17:49:47

Show newer messages


Back to Room ListRoom Version: 9