Nixpkgs Stdenv | 228 Members | |
| 73 Servers |
| Sender | Message | Time |
|---|---|---|
| 11 Jan 2025 | ||
| 21:21:04 | ||
| 13 Jan 2025 | ||
| Updated my POC https://github.com/NixOS/nixpkgs/pull/371613 | 01:15:33 | |
| it is defined in terms of layers (the list of layers is currently static, but should be pretty straightforward to make extendible to be used by things like buildRustPackage. and also finalAttrs is now actually the same as finalPackagethe cross stuff is not better than a few days ago, but I have at least read the splicing and bootstrapping implementations, which should help me | 01:16:08 | |
| * it is defined in terms of layers (the list of layers is currently static, but should be pretty straightforward to make extendible to be used by things like buildRustPackage.) and also finalAttrs is now actually the same as finalPackagethe cross stuff is not better than a few days ago, but I have at least read the splicing and bootstrapping implementations, which should help me | 01:16:28 | |
fwiw finalAttrs.finalPackage.doCheck ≠ finalAttrs.doCheck | 01:20:23 | |
finalPackage has post-processing | 01:20:37 | |
| and ideally splicing would be totally irrelevant to a new construct :) | 01:20:58 | |
| it's only there as a hack for backwards compatibility | 01:21:01 | |
In reply to @emilazy:matrix.orgwell, it is the same now, since finalAttrs = finalPackage The fix point IS the package | 01:30:49 | |
how do you handle doCheck then? | 01:31:02 | |
| It just "extends" the user given value. (I used userValue.doCheck or ...canExecute..., but I could have done userValue.doCheck && ...canExecute...) Just like you would extend nativeBuildInputs with by appending some hooks in the case of buildRustPackage So even though the user wrote some value, the final value might have changed slightly. There is currently a way to access all other layers (e.g. before doCheck was extended), but this introduces correctness problems. | 01:35:18 | |
| * It just "extends" the user given value. (I used userValue.doCheck or ...canExecute..., but I could have done userValue.doCheck && ...canExecute...) Just like you would extend nativeBuildInputs by appending some hooks in the case of buildRustPackage or buildNpmPackage So even though the user wrote some value, the final value might have changed slightly. There is currently a way to access all other layers (e.g. before doCheck was extended), but this introduces correctness problems. | 01:36:06 | |
| But do take a look at the implementation. Also the lowest layer of transformation relies on the entirely undocumented builtins.derivationStrict | 01:37:55 | |
| right | 02:29:33 | |
| I'll try and take a look at some point (quite busy) | 02:29:39 | |
| 14 Jan 2025 | ||
| can someone look at #358042? it's a trivial fix and it's been preventing me from building any flakes for several months. | 17:08:45 | |
| 15 Jan 2025 | ||
| 19:02:58 | ||
| 16 Jan 2025 | ||
| 09:37:40 | ||
| 17 Jan 2025 | ||
| 04:40:34 | ||
| 20 Jan 2025 | ||
| I'm hoping to get https://github.com/NixOS/nixpkgs/pull/365057 approved so I can start working on LLVM bootstrapping without GCC. | 18:25:39 | |
I still think that it's a major footgun and not an improvement over the status quo to have a toolchain variable that is only meant to set a bunch of defaults but that is nonetheless semantically significant and conditioned on in other code | 18:28:51 | |
| it might not be easy to figure out which factors the existing checks care about but it's the only way the change makes sense | 18:29:16 | |
I think the best approach is just to omit toolchain entirely and simply split it up into its constituent factors | 18:30:08 | |
| it's possible some of the checks will end up checking the wrong thing but it's better than being able to do a check that defeats the point of splitting it up | 18:30:22 | |
Then we need a way to detect whether the toolchain is LLVM or not so the usingLLVM conditions can be translated. | 18:31:10 | |
* Then we need a way to detect whether the toolchain is LLVM or not so the useLLVM conditions can be translated. | 18:31:20 | |
| there's no such thing as "the toolchain is LLVM" | 18:31:23 | |
| that's what I keep trying to explain | 18:31:27 | |
| LLVM is a bunch of things and you can pick and choose which parts you use (compatibility permitting) | 18:31:36 | |
hence Darwin using Clang, libc++, libc++abi, but ld64 | 18:32:15 | |