| 17 Dec 2024 |
 Tristan Ross | It might be we have to sort of just try and see how things go | 17:47:02 |
| Tristan Ross | Also, last night I added asserts to prevent people from using the deprecated use* attributes. | 17:47:38 |
| Tristan Ross | I think the new attributes PR is good unless anyone has objections before I merge it. | 17:48:55 |
 Randy Eckenrode | Any impacts on bootstrapping? | 17:49:42 |
| Tristan Ross | None | 17:49:49 |
| Tristan Ross | At least right now | 17:49:57 |
| Tristan Ross | My future goal is this sort of serves as preliminary work on LLVM bootstrapping on Linux. | 17:50:27 |
| Tristan Ross | But it doesn't really have an effect on anything right now. | 17:50:50 |
| Randy Eckenrode | I would like to fix bintools to be LLVM on Darwin in a separate PR. Darwin mostly doesn’t use Apple’s bintools and hasn’t for a while. | 17:51:16 |
| Tristan Ross | Ah, yeah that can be done. | 17:51:41 |
| Tristan Ross | I could do that in the PR which is the next step: making linker work as expected | 17:52:07 |
| Randy Eckenrode | I was looking at doing that for the LLVM bootstrap, but adding Darwin checks everywhere was ugly. It also seemingly can’t use lld. | 17:52:44 |
| Randy Eckenrode | In reply to @rosscomputerguy:matrix.org
I could do that in the PR which is the next step: making linker work as expected I’m not sure the LLVM changes would be right in that case. Is linker meant to be independent of bintools? | 17:54:15 |
| Tristan Ross | Gotcha, yeah I'm not entirely sure how LLVM bootstrapping will be done yet | 17:54:26 |
| Tristan Ross | In reply to @reckenrode:matrix.org
I’m not sure the LLVM changes would be right in that case. Is linker meant to be independent of bintools? Yes | 17:54:32 |
| Randy Eckenrode | I think right now the useLLVM case assumes LLD. Darwin would use LLVM bintools and ld64 (for now). | 17:55:14 |
| Randy Eckenrode | Darwin also needs opted out of libunwind. | 17:56:23 |
| Tristan Ross | Alright, I'll get that done when I work on the linker stuff. We might get a world rebuild from it. | 17:56:35 |
| Randy Eckenrode | That’s why I wanted to do Darwin separately. It’s going to involve cleanup. | 17:56:53 |
| Tristan Ross | Gotcha, do you want it completely separate from the linker PR or just separate from this first one? | 17:57:24 |
| Randy Eckenrode | It could possibly be part of the linker PR if that is updating the LLVM build. | 17:58:03 |
| Tristan Ross | The linker PR might be a bit big since it adjusts things like build systems or where the linker is explicitly defined. | 17:58:09 |
| Tristan Ross | In reply to @reckenrode:matrix.org
It could possibly be part of the linker PR if that is updating the LLVM build. Wdym by updating the LLVM build? | 17:58:31 |
| Randy Eckenrode | Hold on, misread the PR. It’s checking toolchain not bintools. | 17:59:14 |
| Randy Eckenrode | Darwin would still have an apple toolchain. | 17:59:30 |
| Randy Eckenrode | In reply to @rosscomputerguy:matrix.org
Wdym by updating the LLVM build? I was thinking it needed more granularity like if a platform used LLVM bintools, it would default to building them in the LLVM build like it does currently when useLLVM. | 18:00:30 |
| Tristan Ross | Oh gotcha | 18:01:21 |
| Randy Eckenrode | That seems like something to do in a follow up. | 18:01:45 |
| Tristan Ross | Yeah | 18:01:56 |
| Randy Eckenrode | If you can get away with setting bintools to llvm on Darwin now, I’d say go for it. Otherwise, if it requires cleanup, I say do it separately. | 18:02:28 |
