| 9 Nov 2024 |
 emily | hm? | 15:46:27 |
| emily | what changes? | 15:46:30 |
 Tristan Ross | The ones that changes the consumption of `*Platform` -> `stdenv.*Platform` | 15:47:12 |
| Tristan Ross | I think Artturin did that PR | 15:47:26 |
| Tristan Ross | It seems to have messed up the source fetching since Flutter engine sources are based on host and target. | 15:48:03 |
| Tristan Ross | I tried fixing it with overriding stdenv but that didn't help | 15:48:33 |
| emily | that seems really unlikely | 15:49:18 |
| emily | there's no semantic difference | 15:49:22 |
 Artturin | In reply to @rosscomputerguy:matrix.org
It seems to have messed up the source fetching since Flutter engine sources are based on host and target. The pr only unalised the usages | 15:49:26 |
| Artturin | * The pr only unaliased the usages | 15:49:40 |
| Tristan Ross | In reply to @emilazy:matrix.org
there's no semantic difference Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. | 15:50:42 |
| Artturin | In reply to @rosscomputerguy:matrix.org
I tried fixing it with overriding stdenv but that didn't help Overriding the stdenv can change the systems but won't change the cc system | 15:50:50 |
| Artturin | In reply to @rosscomputerguy:matrix.org
Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. Where is it | 15:50:59 |
| Tristan Ross | In reply to @artturin:matrix.org
Overriding the stdenv can change the systems but won't change the cc system I don't need CC for source fetching | 15:51:09 |
| emily | In reply to @rosscomputerguy:matrix.org
Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. something else must have changed. stdenv.isDarwin is the same as stdenv.hostPlatform.isDarwin | 15:51:12 |
| emily | Artturin's PR was 0 rebuilds | 15:51:32 |
| Tristan Ross | In reply to @artturin:matrix.org
Where is it https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/flutter/update/get-engine-hashes.nix.in | 15:52:09 |
| Tristan Ross | In reply to @emilazy:matrix.org
Artturin's PR was 0 rebuilds 0 rebuilds doesn't affect update scripts tho | 15:52:26 |
| emily | the PR didn't even touch this script. | 15:52:40 |
| Tristan Ross | Because I had to change the script since the PR broke it | 15:53:24 |
| emily | In reply to @emilazy:matrix.org
something else must have changed. stdenv.isDarwin is the same as stdenv.hostPlatform.isDarwin ah, I was thinking of another PR. https://github.com/NixOS/nixpkgs/commit/95c1043ff5531b4348c50fa92763954df98399ed touched the flutter stuff | 15:53:31 |
| emily | the inherit stuff I guess | 15:53:52 |
| emily | why is this using templated Nix files? | 15:54:04 |
| Tristan Ross | Because the python update script fills in the template | 15:54:23 |
| emily | I don't quite understand what the Nix is for but surely all the parameterization here could just be --argstr? | 15:55:43 |
| Tristan Ross | It fetches the source so the hash can be determined | 15:56:55 |
| Tristan Ross | The hashes are written out into a JSON file and gets imported later on | 15:57:15 |
| Tristan Ross | I also didn't originally write the updater, I only changed it once I added the flutter engine built from source lol | 15:59:22 |
| emily | yeah, but I mean, Nix is a programming language. you don't need to do "@foo@", you can just… take foo as an argument and pass it with --arg/--argstr when evaluating/building. | 16:06:21 |
| 10 Nov 2024 |
| emily | help: is it normal that gcc and gcc13 are wrapping different GCCs (different bootstrap stages seemingly) with different options even though gcc = pkgs.${"gcc${toString 13}"} | 12:53:26 |
