| 20 Sep 2024 |
 Artturin | * That would be a valid reason to split the change in to a few commits in the same PR | 02:48:10 |
 Tristan Ross | Maybe but still like to review manually | 02:52:18 |
 emily | you're going to manually review >4,000 files? | 11:30:51 |
| emily | I think spot checks are the most we can hope for here | 11:31:02 |
| emily | the important thing is just it getting 0 rebuilds | 11:31:18 |
| Artturin | In reply to @emilazy:matrix.org
the important thing is just it getting 0 rebuilds https://github.com/NixOS/nixpkgs/pull/341407#issuecomment-2353173805 | 11:32:55 |
| emily | right :) | 11:33:19 |
| emily | I shouldn't have said 0 strictly | 11:33:31 |
| emily | I more meant "if we can account for every single rebuild that gives us stronger confidence we're not changing semantics than manual review could" | 11:33:47 |
|  aleksana (force me to bed after 18:00 UTC) joined the room. | 14:13:25 |
|  cafkafk joined the room. | 14:29:50 |
| Tristan Ross | In reply to @emilazy:matrix.org
you're going to manually review >4,000 files? No, I want to review the stuff I am a codeowner/maintainer of. | 16:47:04 |
| Artturin | @rosscomputerguy:matrix.org: try files -> file filter -> files owned by you | 17:39:49 |
| Artturin | https://github.com/orgs/community/discussions/40474#discussioncomment-4411127 | 17:40:18 |
| Tristan Ross | In reply to @artturin:matrix.org
@rosscomputerguy:matrix.org: try files -> file filter -> files owned by you Oh sweet, didn't even knew that button existed. Thanks. | 17:40:53 |
| Artturin | Me neither | 17:41:44 |
| Tristan Ross | 
Download image.png | 17:41:56 |
| Tristan Ross | Oh, this isn't good | 17:41:57 |
| 21 Sep 2024 |
|  linj joined the room. | 05:20:52 |
| 23 Sep 2024 |
|  connor (he/him) (UTC-7) changed their display name from connor (he/him) (UTC-5) to connor (he/him) (UTC-7). | 17:57:50 |
| 24 Sep 2024 |
| emily | Artturin: needs another rebase | 18:58:50 |
| emily | bit of a race against time | 18:59:22 |
| emily | I will hit the button as soon as it merges cleanly and ofborg evals cleanly, ping me if necessary | 18:59:38 |
| Artturin | I don't think it'll be possible to have ofborg evalled and no conflict | 19:00:35 |
| Artturin | We should let it eval now | 19:00:45 |
| Artturin | then rebase and merge immediately | 19:00:51 |
| emily | ok, works for me | 19:02:04 |
| emily | I wasn't sure if ofborg completes eval for conflicted PRs but I guess it started eval before it was conflicted :) | 19:02:19 |
| Artturin | Ofborg said failed to merge so I rebased | 19:20:54 |
| emily | maybe we should just merge and then revert if ofborg looks wrong | 19:50:50 |
