| 9 Nov 2024 |
 emily | is doing stdenv.override { whateverPlatform = …; } meant to work? | 08:43:56 |
| emily | it seems to not regenerate wrappers or anything | 08:44:00 |
| emily | (looking for an LLVM stdenv that targets a different platform. I assume this should not require rebuilding all of LLVM since it's multi-target) | 08:49:12 |
 Artturin | In reply to @emilazy:matrix.org
it seems to not regenerate wrappers or anything CC not overriden automatically
https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/default.nix
you'll have to pass CC yourself https://github.com/NixOS/nixpkgs/blob/a31f2a7b37f2c0cc463768c2637413838da0f35b/pkgs/stdenv/cross/default.nix#L83 | 14:48:04 |
| emily | right | 14:48:25 |
| emily | it seemed like I'd need multiple layers of nested overrides and I resorted to pkgsCross in the end | 14:48:43 |
 Tristan Ross | In reply to @emilazy:matrix.org
is doing stdenv.override { whateverPlatform = …; } meant to work? Oh, that might explain why I see the Flutter engine update script not working after the changes with the platform attributes and using the ones from stdenv. | 15:46:11 |
| emily | hm? | 15:46:27 |
| emily | what changes? | 15:46:30 |
| Tristan Ross | The ones that changes the consumption of `*Platform` -> `stdenv.*Platform` | 15:47:12 |
| Tristan Ross | I think Artturin did that PR | 15:47:26 |
| Tristan Ross | It seems to have messed up the source fetching since Flutter engine sources are based on host and target. | 15:48:03 |
| Tristan Ross | I tried fixing it with overriding stdenv but that didn't help | 15:48:33 |
| emily | that seems really unlikely | 15:49:18 |
| emily | there's no semantic difference | 15:49:22 |
| Artturin | In reply to @rosscomputerguy:matrix.org
It seems to have messed up the source fetching since Flutter engine sources are based on host and target. The pr only unalised the usages | 15:49:26 |
| Artturin | * The pr only unaliased the usages | 15:49:40 |
| Tristan Ross | In reply to @emilazy:matrix.org
there's no semantic difference Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. | 15:50:42 |
| Artturin | In reply to @rosscomputerguy:matrix.org
I tried fixing it with overriding stdenv but that didn't help Overriding the stdenv can change the systems but won't change the cc system | 15:50:50 |
| Artturin | In reply to @rosscomputerguy:matrix.org
Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. Where is it | 15:50:59 |
| Tristan Ross | In reply to @artturin:matrix.org
Overriding the stdenv can change the systems but won't change the cc system I don't need CC for source fetching | 15:51:09 |
| emily | In reply to @rosscomputerguy:matrix.org
Then why does the update script now fetch aarch64-linux for x86_64-linux while host is aarch64-linux. something else must have changed. stdenv.isDarwin is the same as stdenv.hostPlatform.isDarwin | 15:51:12 |
| emily | Artturin's PR was 0 rebuilds | 15:51:32 |
| Tristan Ross | In reply to @artturin:matrix.org
Where is it https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/flutter/update/get-engine-hashes.nix.in | 15:52:09 |
| Tristan Ross | In reply to @emilazy:matrix.org
Artturin's PR was 0 rebuilds 0 rebuilds doesn't affect update scripts tho | 15:52:26 |
| emily | the PR didn't even touch this script. | 15:52:40 |
| Tristan Ross | Because I had to change the script since the PR broke it | 15:53:24 |
| emily | In reply to @emilazy:matrix.org
something else must have changed. stdenv.isDarwin is the same as stdenv.hostPlatform.isDarwin ah, I was thinking of another PR. https://github.com/NixOS/nixpkgs/commit/95c1043ff5531b4348c50fa92763954df98399ed touched the flutter stuff | 15:53:31 |
| emily | the inherit stuff I guess | 15:53:52 |
| emily | why is this using templated Nix files? | 15:54:04 |
