| 3 Aug 2025 |
 emily | it is just being moved around with formatting churn | 12:26:04 |
| emily | in this case the formatting churn goes around conventions, meta is generally not alphabetically-ordered | 12:26:14 |
| emily | and changelog before description and homepage is just weird | 12:26:37 |
| emily | nor do build inputs go after postPatch (there is no strict convention for all of this, but if you are going to do this kind of churn, explicitly making things comply less with the guidelines in https://github.com/jtojnar/nixpkgs-hammering/blob/b0817c8269798a830bc42f58a01c7543e7c5268a/explanations/attribute-ordering.md is hard to justify) | 12:27:32 |
| emily | so "bencode: sort" should be rejected, but checking and fixing the vintage broken comment is not a blocker | 12:28:00 |
| emily | (I can comment as much if you want, but I've found that contributor a little strange to interact with so if you are already reviewing it probably makes sense for you to handle it) | 12:29:11 |
| 4 Aug 2025 |
 Randy Eckenrode | In reply to @emilazy:matrix.org
nor do build inputs go after postPatch (there is no strict convention for all of this, but if you are going to do this kind of churn, explicitly making things comply less with the guidelines in https://github.com/jtojnar/nixpkgs-hammering/blob/b0817c8269798a830bc42f58a01c7543e7c5268a/explanations/attribute-ordering.md is hard to justify) Is this documented anywhere as the convention to use? I’ve been grouping by phases (so build phase stuff together, etc) …. | 23:24:34 |
| emily | I don't think there's any real consensus, but I think the nixpkgs-hammering ordering is something close to what's most common (i.e. probably many packages violate it in some way or another but if you were going to write down the most consistent set of rules you could based on patterns of relative ordering it would be close to that) | 23:25:41 |
| emily | I think some things are pretty strong consensus (passthru and meta last, pname, version, src, and usually outputs and patches before other stuff) | 23:26:31 |
| emily | and everything in between is a little fuzzy | 23:26:35 |
| 5 Aug 2025 |
|  Axel Karjalainen joined the room. | 17:39:37 |
| Axel Karjalainen | Was there any reason for libcCrossChooser to use targetPackages? See also my comment here: https://github.com/NixOS/nixpkgs/pull/409851#discussion_r2254887700
Is this the right Matrix room for this?
| 17:51:17 |
 vcunat | #cross-compiling:nixos.org also exists, but I don't know what's the best place. | 17:54:58 |
