Sender | Message | Time |
---|---|---|
26 May 2025 | ||
I think libc++ passes one and Rust passes another and so on and so forth | 11:37:20 | |
autotools treats -macos as classic macOS IIRC, or at least -macos9 maybe | 11:37:39 | |
my suspicion was that -macosx would be more palatable to the non-Apple/LLVM ecosystem, but it does have the drawback that we're standardizing on a name that has been out of date for many years | 11:38:05 | |
Note that the default target would still be <arch>-apple-darwin . The translation would happen in the wrapper when invoking the unwrapped compiler. | 11:42:58 | |
In reply to @emilazy:matrix.orgaarch64-darwin unconditionally includes the hook by default in its stdenv. | 11:43:59 | |
I see | 11:43:59 | |
then I doubt that'd cause issues, but to me it'd be nice to use it as the actual target. | 11:44:12 | |
since it is more accurate and precise | 11:44:29 | |
I just gave up because I didn't feel like fighting autotools when the freeze was in sight | 11:44:37 | |
In reply to @emilazy:matrix.orgDo they still require copyright assignment? | 11:44:42 | |
not sure. some GNU projects stopped doing that. | 11:44:53 | |
I didn't realize this. but surely upstream does support it these days right? | 11:45:06 | |
I guess in that case it would be fine but I'd still prefer not to patch autotools in ways upstream explicitly rejects. we could just ask them about it I suppose. | 11:45:26 | |
In reply to @emilazy:matrix.orgAFAIK he’s upstreaming his work. It’s just taking a while. We should probably apply the patch on both platforms …. | 11:45:42 | |
we could just apply it unconditionally, it shouldn't break cross now… | 11:46:42 | |
but that's a pretty huge GCC patch to apply | 11:46:48 | |
at least it doesn't touch other platforms really | 11:47:00 | |
(I believe he's a GCC committer?) | 11:47:07 | |
In reply to @emilazy:matrix.orgI would go with whatever Swift does because AFAIK it only supports one wayS | 11:49:59 | |
In reply to @emilazy:matrix.org* | 11:50:03 | |
In reply to @emilazy:matrix.orgMy goal is to align what we pass to the unwrapped compiler to what Swift is doing and relax the target check because otherwise very build causes tons of log spam. The wrapper can accept all the variants and do the mapping if that’s what keeps various build systems happy. | 11:52:09 | |
In reply to @emilazy:matrix.org* | 11:52:22 | |
fair enough, I agree if we have to choose between the two then matching Swift is good. I expect macosx has wider compatibility anyway. | 11:52:39 | |
do you want my diff from when I was trying -macosx and when I was trying -darwin<kernel version> ? | 11:53:06 | |
you could combine those and if you teach a hook to teach autotools about it you can probably get a lot further testing it than me. | 11:53:20 | |
In reply to @emilazy:matrix.orgSure. | 11:58:12 | |
In reply to @emilazy:matrix.orgEspecially if we adopt Swift Build to replace xcbuild. | 11:58:35 | |
But boy does that thing have a ton of impurities …. | 11:58:55 | |
https://github.com/emilazy/nixpkgs/commits/push-vsxoyyworlsz is including the Darwin kernel versions. IIRC I ran into issues with this that made me postpone it to post-release but I forget where. https://github.com/emilazy/nixpkgs/commits/push-rkpovppmolzv is using you probably know this, but for | 12:19:03 | |
we might want something in the kernel struct for if isMacOS then "darwin" else parsed.kernel.name since it seems to come up a lot, but OTOH a lot of those instances already have other special cases that I just extended, so maybe it'd be better to have go.* and node.* and stuff like we have rust.* … | 12:20:39 |