| 24 Nov 2023 |
 Artturin | https://github.com/NixOS/nixpkgs/issues/269539 | 01:41:21 |
 hexa | firefox on release-23.05 crashes due to the way how libstdc++ gets linked into firefox and I'm completely out of my depth | 13:02:04 |
| hexa | https://github.com/NixOS/nixpkgs/issues/269571#issuecomment-1825621198 | 13:02:05 |
| hexa | only affects 23.05, both 23.11 and unstable seem fine | 13:02:52 |
|  nbp joined the room. | 13:43:03 |
|  yannis joined the room. | 13:44:11 |
 trofi | If firefox is linked by clang I wonder if cc-wrapper was supplying only libstdc++.a library in it's library search paths. Something like https://github.com/NixOS/nixpkgs/commit/2946b819c209f4a1a9e87a725fc9e5ed2452c178 might nave been a fix. You should be able to add needed library search path with explicit -L to firefox. | 14:16:01 |
| nbp | This sounds like it is build using clang, to make use of LTO:
https://github.com/NixOS/nixpkgs/blob/8f1180704ac35baded1a74164365ac7cdfba6f38/pkgs/applications/networking/browsers/firefox/common.nix#L171-L174 | 14:21:33 |
| trofi | Yeah, clang++ uses static libstdc++ in nixos-23.05 branch:
$ nix develop -f. firefox-unwrapped
$ dev>printf "#include <iostream>\nint main() { std::cout << 'x'; }" | clang++ -x c++ - -o a -Wl,-t |& fgrep stdc |& head -n3
/nix/store/jma71mvzwdrcm6qc5izvskvzfsii5mk7-gcc-11.3.0/lib64/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../lib64/libstdc++.a(globals_io.o)
/nix/store/jma71mvzwdrcm6qc5izvskvzfsii5mk7-gcc-11.3.0/lib64/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../lib64/libstdc++.a(ios_init.o)
/nix/store/jma71mvzwdrcm6qc5izvskvzfsii5mk7-gcc-11.3.0/lib64/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../lib64/libstdc++.a(eh_personality.o)
| 14:24:44 |
| trofi | staging-next for comparison uses shared one:
$ nix develop -f. firefox-unwrapped
$ dev>printf "#include <iostream>\nint main() { std::cout << 'x'; }" | clang++ -x c++ - -o a -Wl,-t |& fgrep stdc |& head -n3
/nix/store/myw67gkgayf3s2mniij7zwd79lxy8v0k-gcc-12.3.0-lib/lib/libstdc++.so
| 14:25:48 |
| nbp | Would cherry-picking the change fix the issue? | 14:26:38 |
| nbp | Or should we look at something specific for Firefox? | 14:26:52 |
| nbp | * Or should we should look at something specific for Firefox? | 14:26:59 |
| trofi | I think cherry-pick will be a world rebuild. I would suggest exploring local to firefox fix like adding an equivalent of NIX_LDFLAGS = "-L${stdenv.cc.cc.lib}/lib" under stdenv.isGNU. | 14:28:41 |
| nbp | hexa: Does that sounds good? ^ | 14:29:43 |
| hexa | sure, we can try that | 14:31:58 |
| hexa | thanks trofi! | 14:32:36 |
| hexa | Artturin: what is your intention with the staging-23.05 backport here? https://github.com/NixOS/nixpkgs/pull/192459#event-10971886154 | 15:28:48 |
| hexa | * Artturin: what is your plan with the staging-23.05 backport here? https://github.com/NixOS/nixpkgs/pull/192459#event-10971886154 | 15:28:52 |
| Artturin | In reply to @hexa:lossy.network
Artturin: what is your plan with the staging-23.05 backport here? https://github.com/NixOS/nixpkgs/pull/192459#event-10971886154 merged | 15:31:03 |
| 28 Nov 2023 |
|  a-n-n-a-l-e-e joined the room. | 03:19:26 |
| 4 Dec 2023 |
|  Philip Taron (UTC-8) joined the room. | 20:56:40 |
| 5 Dec 2023 |
|  Federico Damián Schonborn changed their profile picture. | 00:38:34 |
 raitobezarius | does the stdenv people knows why checkMeta might have missed those: https://github.com/NixOS/nixpkgs/pull/272199 ? | 14:50:43 |
| raitobezarius | I also realized we have stdenv.meta = null derivations for some bootstrap stuff BTW | 14:50:57 |
| Artturin | In reply to @raitobezarius:matrix.org
does the stdenv people knows why checkMeta might have missed those: https://github.com/NixOS/nixpkgs/pull/272199 ? https://github.com/NixOS/nixpkgs/blob/70475eb9dd8e0a3b7138cf829f96cb404fa1d94b/pkgs/stdenv/generic/check-meta.nix#L310 | 15:47:26 |
| raitobezarius | I see | 15:50:23 |
| raitobezarius | Thank you! | 15:50:25 |
| Artturin | https://github.com/NixOS/nixpkgs/issues/272290 | 15:52:55 |
| Artturin | created an issue | 15:53:04 |
